fix(bedrock): Grant delete vectors permission to knowledge base execution role#1306
Conversation
|
Thanks @gazoakley , I think the fix looks good, have you tested it already to confirm ? If yes, we can make the PR ready and ship it. |
aa3ca73 to
39d9931
Compare
39d9931 to
d0b73a6
Compare
|
hi @gazoakley , just checking if the PR is ready for review ? Thanks ! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
========================================
Coverage 95.34% 95.34%
========================================
Files 87 87
Lines 26698 26699 +1
Branches 785 479 -306
========================================
+ Hits 25455 25456 +1
Misses 1243 1243 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label. |
Hi @krokoko - in theory it works, but I haven't been able to get |
e193e2b to
fe7636e
Compare
Yes I would like to test it to verify before shipping, let me do a test this week |
|
testing now |
|
Tested, fix works as expected @gazoakley thanks for this ! |

Fixes #1305
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.