Skip to content

Fix: create_config TypeError when read_timeout is passed via config #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evanerwee wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −9
Open

Fix: create_config TypeError when read_timeout is passed via config #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions lexical-graph/src/graphrag_toolkit/lexical_graph/storage/graph/neptune_graph_stores.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,11 @@ def create_config(config:Optional[str]=None):

config_args.setdefault('max_pool_connections', DEFAULT_MAX_POOL_CONNECTIONS)

return Config(
retries={
'total_max_attempts': 1,
'mode': 'standard'
},
read_timeout=600,
user_agent_appid=f'graphrag-lexical-graph-{toolkit_version}',
**config_args
)
config_args.setdefault('read_timeout', 600)
config_args.setdefault('retries', {'total_max_attempts': 1, 'mode': 'standard'})
config_args.setdefault('user_agent_appid', f'graphrag-lexical-graph-{toolkit_version}')

@mykola-pereyma mykola-pereyma Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks correct and follows same pattern already used for max_pool_connections above. Could you add regression tests for the three fields that were breaking? The existing TestCreateConfig class in test_neptune_graph_stores.py already has this pattern for max_pool_connections so should be straightforward. Without regression tests there is nothing preventing someone from refactoring this back to kwargs and reintroducing the TypeError.

return Config(**config_args)

def create_property_assigment_fn_for_neptune(key:str, value:Any) -> Callable[[str], str]:
"""
Expand Down