fix(lexical-graph): avoid duplicate Neptune Config arguments#396
Open
marora90 wants to merge 2 commits into
Open
fix(lexical-graph): avoid duplicate Neptune Config arguments#396marora90 wants to merge 2 commits into
marora90 wants to merge 2 commits into
Conversation
When a user passes read_timeout (or retries, user_agent_appid) via the config JSON string, Config() receives duplicate keyword arguments and raises TypeError. The fix uses setdefault() for all hardcoded values — the same pattern already used for max_pool_connections on the line immediately above. User-provided values take precedence; defaults apply when absent. Fixes awslabs#361 (cherry picked from commit 78ea17b)
oussamahansal
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continues #368 by @evanerwee. Their original commit was cherry-picked to preserve authorship, and this PR adds the regression coverage requested in review.
This fixes
create_config()so user-provided botocore config values override the defaults.Fixes #361.
Testing
pytest)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.