Skip to content

fix(lexical-graph): avoid duplicate Neptune Config arguments #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marora90 wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −9
Open

fix(lexical-graph): avoid duplicate Neptune Config arguments #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dcca13
Fix: create_config TypeError when user passes read_timeout
evanerwee Jun 30, 2026
4022c3c
Add regression tests for Neptune create_config overrides
marora90 Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions lexical-graph/src/graphrag_toolkit/lexical_graph/storage/graph/neptune_graph_stores.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,11 @@ def create_config(config:Optional[str]=None):

config_args.setdefault('max_pool_connections', DEFAULT_MAX_POOL_CONNECTIONS)

return Config(
retries={
'total_max_attempts': 1,
'mode': 'standard'
},
read_timeout=600,
user_agent_appid=f'graphrag-lexical-graph-{toolkit_version}',
**config_args
)
config_args.setdefault('read_timeout', 600)
config_args.setdefault('retries', {'total_max_attempts': 1, 'mode': 'standard'})
config_args.setdefault('user_agent_appid', f'graphrag-lexical-graph-{toolkit_version}')

return Config(**config_args)

def create_property_assigment_fn_for_neptune(key:str, value:Any) -> Callable[[str], str]:
"""
Expand Down
21 changes: 21 additions & 0 deletions lexical-graph/tests/unit/storage/graph/test_neptune_graph_stores.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,27 @@ def test_user_agent_set(self):
cfg = create_config()
assert 'graphrag-lexical-graph' in cfg.user_agent_appid

@pytest.mark.parametrize(
"config_key, config_value, cfg_attr",
[
('read_timeout', 30, 'read_timeout'),
(
'retries',
{'total_max_attempts': 3, 'mode': 'adaptive'},
'retries',
),
('user_agent_appid', 'custom-app', 'user_agent_appid'),
],
)
def test_user_args_override_default_config_kwargs_without_type_error(
self,
config_key,
config_value,
cfg_attr,
):
cfg = create_config(_json.dumps({config_key: config_value}))
assert getattr(cfg, cfg_attr) == config_value


class TestCreatePropertyAssignmentFn:
def test_non_datetime_key_returns_identity(self):
Expand Down