Skip to content

Profiler: add StringColumnProfile#248

Merged
sudsali merged 12 commits into
awslabs:masterfrom
nikie:profiler-string-column-profile
May 9, 2026
Merged

Profiler: add StringColumnProfile#248
sudsali merged 12 commits into
awslabs:masterfrom
nikie:profiler-string-column-profile

Conversation

@nikie

@nikie nikie commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Issue #, if available:
#247

Description of changes:
Adding StringColumnProfile as a subclass of StandardColumnProfile to expose the additional results available for string columns in Scala - minLength and maxLength.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nikie nikie changed the title Profiler: add StringColumnProfile. Profiler: add StringColumnProfile Jun 3, 2025

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: 8c93b14f) — may not be fully accurate. Reply if this doesn't help.

Comment thread tests/test_profiles.py Outdated
Comment thread tests/test_profiles.py Outdated
Comment thread tests/test_profiles.py Outdated
Comment thread pydeequ/profiles.py
Comment thread pydeequ/profiles.py

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: 8c93b14f) — may not be fully accurate. Reply if this doesn't help.

Comment thread tests/test_profiles.py

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: 8c93b14f) — may not be fully accurate. Reply if this doesn't help.

Comment thread tests/test_profiles.py Outdated
@nikie nikie force-pushed the profiler-string-column-profile branch from 8db7c37 to 176760b Compare May 4, 2026 21:40
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

No issues found.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: 8c93b14f) — may not be fully accurate. Reply if this doesn't help.

@sudsali

sudsali commented May 7, 2026

Copy link
Copy Markdown
Contributor

@nikie Can you please resolve the conflicts in the PR?

@nikie nikie force-pushed the profiler-string-column-profile branch from 176760b to df37150 Compare May 7, 2026 16:19

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: a3be7c83) — may not be fully accurate. Reply if this doesn't help.

Comment thread pydeequ/profiles.py
Comment thread pydeequ/profiles.py
Comment thread tests/test_profiles.py

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: a3be7c83) — may not be fully accurate. Reply if this doesn't help.

Comment thread tests/test_profiles.py Outdated
Comment thread tests/test_profiles.py Outdated
Comment thread pydeequ/profiles.py
Comment thread pydeequ/profiles.py

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: a56fe40f) — may not be fully accurate. Reply if this doesn't help.

Comment thread pydeequ/profiles.py
Comment thread tests/test_profiles.py Outdated
Comment thread tests/test_profiles.py
@nikie nikie force-pushed the profiler-string-column-profile branch from cf12315 to c961d0b Compare May 7, 2026 22:12

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: a56fe40f) — may not be fully accurate. Reply if this doesn't help.

Comment thread tests/test_profiles.py
Comment thread pydeequ/profiles.py

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: a56fe40f) — may not be fully accurate. Reply if this doesn't help.

Comment thread tests/test_profiles.py
Comment thread pydeequ/profiles.py
Comment thread tests/test_profiles.py Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: a56fe40f) — may not be fully accurate. Reply if this doesn't help.

Comment thread tests/test_profiles.py Outdated
Comment thread pydeequ/profiles.py
Comment thread tests/test_profiles.py

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: a56fe40f) — may not be fully accurate. Reply if this doesn't help.

Comment thread tests/test_profiles.py
Comment thread pydeequ/profiles.py

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: a56fe40f) — may not be fully accurate. Reply if this doesn't help.

Comment thread pydeequ/profiles.py
Comment thread tests/test_profiles.py
Comment thread pydeequ/profiles.py

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: a56fe40f) — may not be fully accurate. Reply if this doesn't help.

Comment thread tests/test_profiles.py
Comment thread pydeequ/profiles.py
@nikie

nikie commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

@nikie Can you please resolve the conflicts in the PR?

Hi, @sudsali , could you, please, review again?
After I resolved the conflict through rebasing the bot spun out of control a bit. They might have had a bad day or something :)
However, a decent number of complaints was reasonable indeed and allowed to make the code better.

@sudsali sudsali left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nikie for the contribution!

@sudsali sudsali merged commit cd60ca6 into awslabs:master May 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants