Skip to content

Commit 6d9eb38

Browse files
ax3lclaude
andcommitted
Wheels: valid artifact name for Windows ARM64 leg
With the -A ARM64 fix the windows-11-arm wheels build and pass tests (HDF5 + JSON round-trip, 0 external deps), but the job failed at upload: the artifact name wheels-${os}-${build||arch} interpolated this leg's build glob ("cp311-* cp312-* ..."), and '*'/spaces are invalid in an artifact name. Add an optional matrix.artifact override (default: build || arch) and set it to "ARM64" for the windows-11-arm leg -> wheels-windows-11-arm-ARM64. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent e49bbac commit 6d9eb38

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

.github/workflows/build.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525
# platform CIBW_PLATFORM (default auto)
2626
# build CIBW_BUILD (default *, i.e. all)
2727
# patches space-separated setup patches (default: Windows one)
28+
# artifact artifact-name suffix override (default: build || arch)
2829
# sdist also build + upload the sdist artifact (default: off)
2930
include:
3031
- os: ubuntu-22.04
@@ -67,6 +68,7 @@ jobs:
6768
- os: windows-11-arm
6869
arch: "ARM64"
6970
build: "cp311-* cp312-* cp313-* cp314-*"
71+
artifact: "ARM64" # build has '*'/spaces; not a valid artifact name
7072
env:
7173
ADIOS2: "OFF"
7274
CMAKE_GENERATOR_PLATFORM: "ARM64"
@@ -265,8 +267,9 @@ jobs:
265267
name: Publish as GitHub artifact
266268
with:
267269
# Include matrix.build so the two wasm legs (cp313 / cp314, which share
268-
# os=ubuntu-24.04 + arch=wasm32) get DISTINCT artifact names.
269-
name: wheels-${{ matrix.os }}-${{ matrix.build || matrix.arch }}
270+
# os=ubuntu-24.04 + arch=wasm32) get DISTINCT artifact names. matrix.artifact
271+
# overrides it where build holds glob chars invalid in a name (Windows ARM64).
272+
name: wheels-${{ matrix.os }}-${{ matrix.artifact || matrix.build || matrix.arch }}
270273
path: ./wheelhouse
271274
overwrite: true
272275

0 commit comments

Comments
 (0)