Skip to content

Commit b94f7a6

Browse files
authored
Remove Inline Comments
Historic character comments are confusing and unnecessary. Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
1 parent 6f21c50 commit b94f7a6

2 files changed

Lines changed: 1 addition & 16 deletions

File tree

.github/workflows/build.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,6 @@ jobs:
3838
env:
3939
ADIOS2: "OFF"
4040

41-
# Linux ARM64 (aarch64): native GitHub-hosted runner, free for public
42-
# repos (cibuildwheel builds aarch64 natively, no QEMU). Full parity with
43-
# the x86_64 leg above: cp310-cp314, many + musl, ADIOS2 ON.
44-
# (Formerly built on Travis-CI, which is retired.)
4541
- os: ubuntu-24.04-arm
4642
arch: "aarch64"
4743

@@ -67,11 +63,6 @@ jobs:
6763
CMAKE_GENERATOR_PLATFORM: "Win32"
6864
ADIOS2: "OFF" # 32-bit: no 32-bit ADIOS2 CI; BP read segfaults (see i686)
6965

70-
# Windows ARM64: native GitHub-hosted runner, free for public repos
71-
# (cibuildwheel ARM64 support is still experimental). CPython win_arm64
72-
# exists only from 3.11+, so no cp310 and no PyPy here. First cut ships
73-
# HDF5 + JSON only (ADIOS2 OFF) to avoid an unproven ADIOS2-on-ARM64 build;
74-
# library_builders.bat then compiles only zlib + HDF5. See i686/win32.
7566
- os: windows-11-arm
7667
arch: "ARM64"
7768
build: "cp311-* cp312-* cp313-* cp314-*"

library_builders.bat

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -290,13 +290,7 @@ call :install_buildessentials
290290
call :build_zlib
291291
call :build_hdf5
292292

293-
rem ADIOS2 and its exclusive dependencies (SQLite3, ZFP, C-Blosc2) are only built
294-
rem when openPMD is configured with ADIOS2 (openPMD_CMAKE_openPMD_USE_ADIOS2=ON, set
295-
rem via CIBW_ENVIRONMENT_WINDOWS and visible here in the before-build step). Targets
296-
rem that ship HDF5 + JSON only -- Windows ARM64 and win32 (x86) -- skip this whole
297-
rem chain, which avoids an unproven ADIOS2-on-ARM64 build and trims the required
298-
rem tooling to curl + PowerShell + CMake. HDF5 depends only on zlib, so it stays
299-
rem unconditional above.
293+
rem ADIOS2 and its exclusive dependencies
300294
if /I "%openPMD_CMAKE_openPMD_USE_ADIOS2%"=="ON" (
301295
call :build_sqlite
302296
rem build_bzip2

0 commit comments

Comments
 (0)