Updates to variable-based encoding#1
Merged
ax3l merged 5 commits intoOct 25, 2022
Merged
Conversation
11 tasks
ax3l
reviewed
Oct 12, 2022
ax3l
reviewed
Oct 12, 2022
ax3l
reviewed
Oct 12, 2022
ax3l
reviewed
Oct 12, 2022
| double /data/meshes/E/x/unitSI 10*scalar | ||
| double /data/meshes/E/unitDimension attr = {0, 0, 0, 0, 0, 0, 0} | ||
| int32_t /data/meshes/E/x {1000} | ||
| double /data/meshes/E/x/position attr = 0 |
ax3l
reviewed
Oct 12, 2022
ax3l
reviewed
Oct 12, 2022
|
|
||
| Notes: | ||
|
|
||
| * In implementations without support for IO steps, the variable-based encoding of iterations may still be used for storage of a single iteration. |
Owner
There was a problem hiding this comment.
In these points, the new wording using IO steps might be confusing?
Author
There was a problem hiding this comment.
I've reworded that to support for storing multiple versions of datasets/attributes, which I think is more explicit anyway.
ax3l
reviewed
Oct 12, 2022
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Make the example more realistic, also minor fixes
ax3l
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snapshotattribute as in Mapping between ADIOS steps and openPMD iterations openPMD/openPMD-api#949