test/multicqes drain#1603
Open
schlad wants to merge 2 commits into
Open
Conversation
schlad
force-pushed
the
multicqes_drain
branch
3 times, most recently
from
a3bd366 to
bb21ce0
Compare
Signed-off-by: Sebastian Chlad <sebastian.chlad@suse.com>
multi_cap is a global that caps the number of multishot SQEs per run. It gets decremented during SQE generation but was never reset between iterations, so calls 2-5 of test_generic_drain() could not generate any multishot SQEs (multi_cap <= 0 makes retry1 always true). With no multishot SQEs, cancel ops are also excluded (cnt stays 0), leaving only single and nop ops for those iterations. Reset multi_cap at the start of each call. Signed-off-by: Sebastian Chlad <sebastian.chlad@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multi_cap is a global that caps the number of multishot SQEs per run.
It gets decremented during SQE generation but was never reset between
iterations, so calls 2-5 of test_generic_drain() could not generate any
multishot SQEs (multi_cap <= 0 makes retry1 always true). With no
multishot SQEs, cancel ops are also excluded (cnt stays 0), leaving
only single and nop ops for those iterations.
Reset multi_cap at the start of each call.