test/reg-fd-only: Relax io_uring_submit() return value check#1605
Open
chrehrhardt wants to merge 1 commit into
Open
test/reg-fd-only: Relax io_uring_submit() return value check#1605chrehrhardt wants to merge 1 commit into
chrehrhardt wants to merge 1 commit into
Conversation
For SQPOLL rings the man page of io_uring_submit(3) states that the return value can be higher than the number of submitted SQEs and on a very slow overloaded system we sometimes see the test fail with: | short submit 16 | test 8 failed To fix this, allow the return value to be higher than expected. Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
Collaborator
|
Make sense to me. We are submitting 32nops in batches of 8. If sqpoll didn't see the full previous 8, __io_uring_flush_sq can report a higher value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For SQPOLL rings the man page of io_uring_submit(3) states that the return value can be higher than the number of submitted SQEs and on a very slow overloaded system we sometimes see the test fail with:
| short submit 16
| test 8 failed
To fix this, allow the return value to be higher than expected.