Refactor legacy text input stack to ui::InputField and unify font handling APIs by halx99 · Pull Request #3173 · axmolengine/axmol

halx99 · 2026-05-19T03:34:48Z

Describe your changes

Replace legacy TextFieldTTF usage/removal and shift text input flows toward ui::InputField/IME-based behavior.
Add unified Label::create(text, fontName, fontSize) API with automatic font-type detection (BMFont/TTF/system font).
Add Label::setFontInfo(fontName, fontSize) to centralize runtime font switching.
Clean up Label internals by removing cached _lengthOfString state and deriving count from UTF-32 text (getCharCount()), reducing stale-length risks.
Introduce/rename clearer label query APIs (getLineCount(), getCharCount()) while keeping backward-compatible deprecated wrappers.
Harden UTF-8 handling paths in label/text operations (avoid accepting invalid UTF-8 silently).
Update desktop/input related plumbing and scene/UI compatibility touchpoints associated with the migration.
Apply broad cleanup/modernization in tests and headers (e.g., #pragma once, include path corrections, minor code hygiene).
Integrate iOS System Copy/Paste Menu for InputField Editing

Issue ticket number and link

Checklist before requesting a review

For each PR

Add Copyright if it missed:
- "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.

Optional:
- I have checked readme and add important infos to this PR.
- I have added/adapted some tests too.

For core/new feature PR

I have checked readme and add important infos to this PR.
I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

Check the '#include "axmol.h"' and replace it with the needed headers.

halx99 · 2026-05-19T03:36:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 211c215351

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

halx99 · 2026-05-20T03:28:59Z

/clang-format

halx99 · 2026-05-20T03:49:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2aff1905b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

halx99 · 2026-05-24T09:12:29Z

@codex Again, provide merge title and change detail list about this PR via https://patch-diff.githubusercontent.com/raw/axmolengine/axmol/pull/3173.diff

halx99 · 2026-05-24T09:12:34Z

/clang-format

halx99 · 2026-05-24T09:12:43Z

@codex review

halx99 · 2026-05-24T09:26:20Z

@gemini review

gemini-code-assist

Code Review

This pull request refactors the UI and text input systems, replacing legacy TextField components with a new InputField widget and introducing a cross-platform clipboard API. It also updates the layout system by replacing ignoreContentAdaptWithSize with setAutoSize and renames various UI headers for consistency. Feedback highlights critical logic inversions in the setAutoSize implementation for several widgets (Button, ImageView, Slider, and LoadingBar) when Scale9 is enabled, which hinders manual sizing. Further improvements are suggested for Android clipboard robustness, touch position tracking in InputField, and optimizing the O(N^2) performance of the text layout measurement logic.

gemini-code-assist · 2026-05-24T09:38:14Z

Hello halx99, thank you for reaching out. Regarding your question about the ui::InputField implementation, it is designed to be a more modern, IME-friendly replacement for the legacy TextFieldTTF.

Key improvements include:

IME Integration: It utilizes the new InputDelegate and InputDispatcher architecture, which provides better support for platform-native IME features (like pre-edit text updates) compared to the legacy IMEDelegate.
Cursor & Selection: It includes built-in cursor management and selection handling, which were significant pain points in the legacy implementation.
Font Flexibility: The unified Label::create(text, fontName, fontSize) API allows for easier font handling across different types (BMFont, TTF, System).
Performance: By deriving character counts from UTF-32 text (getCharCount()) and removing stale state like _lengthOfString, it reduces synchronization risks and improves performance.

If you are looking to migrate from TextFieldTTF or TextField, I recommend focusing on the InputField factory methods and the event-based listener system (addEventListener) to handle input changes, as this is the intended pattern for the new stack. Let me know if you have specific architectural questions or need help with a particular use case!

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

halx99 · 2026-05-24T10:21:21Z

@gemini review

gemini-code-assist

Code Review

This pull request performs a major refactoring of the UI and input systems, replacing the deprecated TextFieldTTF and TextFieldEx widgets with a new InputField component that supports multiline text, cursors, and selections. The refactor includes a widespread renaming of UI classes and core methods (e.g., setAutoSize, getRenderNode) to improve API consistency, renames the IME system to a more general Input system, and introduces a cross-platform clipboard API. Review feedback identifies a high-severity risk of null pointer exceptions in the Android clipboard implementation and suggests adopting safer string access patterns in the InputField logic.

halx99 · 2026-05-24T10:31:41Z

/clang-format

halx99 · 2026-05-24T12:50:11Z

/clang-format

halx99 · 2026-05-24T13:00:34Z

/gemini review

gemini-code-assist

Code Review

This pull request overhauls the text input and UI widget systems by introducing a modern InputField component to replace the deprecated TextFieldTTF and TextFieldEx. The new InputField supports multiline text, cursor control, selection, and native clipboard integration. Additionally, the Widget base class and its derivatives have been refactored to use a standardized setAutoSize and initRenderNode API, and the IME system has been renamed to InputDelegate. Reviewer feedback highlights significant efficiency and correctness concerns regarding character-by-character text measurement and the lack of word-level wrapping in multiline mode. Other actionable suggestions include syncing measurement labels with rendering effects, adjusting long-press trigger timing on mobile platforms, and correcting a typo in Label.cpp.

gemini-code-assist · 2026-05-24T13:11:44Z

+        {
+            size_t nextByteOffset = _charByteOffsets[currentCharIdx + 1];
+            std::string_view charView(_inputText.data() + charByteOffset, nextByteOffset - charByteOffset);
+            charWidth = measureText(charView).width;


Measuring text character-by-character in a loop is extremely inefficient (O(N) heavy label updates) and typographically incorrect. It ignores kerning and ligatures, which will result in inaccurate cursor positioning for many fonts and languages. A better approach would be to measure the entire string and extract glyph positions from the FontAtlas or use Label's internal layout data if it can be exposed.

gemini-code-assist · 2026-05-24T13:11:44Z


+void Label::setFontInfo(std::string_view fontName, float fontSize)
+{
+    auto prevLableType = _currentLabelType;


Typo in variable name: prevLableType should be prevLabelType.

auto prevLabelType = _currentLabelType;

gemini-code-assist · 2026-05-24T13:11:44Z

+    // Lazy initialize instance-specific measure label
+    if (!_measureLabel)
+    {
+        _measureLabel = Label::create(""sv, _fontName, _fontSize);


The _measureLabel is initialized with the font name and size, but it is never updated if the _renderLabel is subsequently modified with effects like outline or shadow. This will cause character width measurements to be incorrect, leading to cursor misalignment. Consider implementing a mechanism to sync the measure label's configuration with the render label.

gemini-code-assist · 2026-05-24T13:11:45Z

+    }
+
+    // If the Label exposes internal padding or baseline offsets, apply them here.
+    // Example (pseudo): textBottomYInLabel += _renderLabel->getInternalPaddingBottom();


This pseudo-code comment should be removed or implemented if it was intended to handle internal padding.

gemini-code-assist · 2026-05-24T13:11:45Z

+        Vec2 localPoint = this->convertToNodeSpace(worldPoint);
+        moveCursorTo(localPoint, _selectionTouchMoved);
+
+        if (_continuousTouchPending && _continuousTouchElapsedTime >= _continuousTouchDelayTime)


The continuous touch (long press) logic only triggers the menu when the touch ends. Standard mobile behavior for text fields is to show the loupe or edit menu while the user is still holding the finger down. Consider moving the trigger logic to updateLayout or a timer callback.

gemini-code-assist · 2026-05-24T13:11:45Z

+        if (_multilineEnabled && currentCharIdx > currentLine.startCharIndex)
+        {
+            // If adding this character exceeds available width, commit current line before tracking it
+            if (currentLine.charXOffsets.back() + charWidth > availableWidth)


The current multiline wrapping logic implements character-level wrapping, which breaks words in the middle. Most UI text inputs expect word-level wrapping. Consider implementing a word-wrap algorithm that looks for whitespace when a line exceeds the available width.

halx99 added 14 commits May 16, 2026 22:19

input-field-step1

d761ad8

up

d075958

up

4eb10db

up

720d064

up

cf21e33

up

82b15b8

fix cursor postion when horiz alignemt not left

bde0823

up

a16d94d

Clenaup code

f60fbe7

up

a39b238

up

431911e

up

638bf82

up

8f85460

up

211c215

halx99 added this to the 3.0.0 milestone May 19, 2026

halx99 linked an issue May 19, 2026 that may be closed by this pull request

Unify Input control: ui::TextField, TextFieldTTF, ui::TextFieldEx #3168

Open

halx99 changed the title ~~Input field~~ Implement #3168 May 19, 2026

chatgpt-codex-connector Bot reviewed May 19, 2026

View reviewed changes

Comment thread axmol/ui/UIWidget.cpp Outdated

Comment thread extensions/scripting/lua-bindings/auto/axlua_ui_auto.cpp Outdated

halx99 added 5 commits May 19, 2026 16:18

up

486ec1e

luabindings

42c0610

Fix luabindings

3d383c0

Improve API style

1368c5a

up

bb6dff5

Committing clang-format changes

d2aff19

chatgpt-codex-connector Bot reviewed May 20, 2026

View reviewed changes

Comment thread extensions/sceneio/src/sceneio/WidgetReader/WidgetReader.cpp Outdated

Comment thread axmol/ui/UIButton.cpp Outdated

Comment thread axmol/ui/UIWidget.cpp Outdated

Comment thread axmol/ui/InputField.cpp Outdated

halx99 added 2 commits May 20, 2026 12:07

fix reviews

d95931b

fix reviews

06e07b8

Fix reviews

d3ed0b9

Committing clang-format changes

59497c8

axmolengine deleted a comment from chatgpt-codex-connector Bot May 24, 2026

Fixup

36a79ba

gemini-code-assist Bot reviewed May 24, 2026

View reviewed changes

halx99 and others added 4 commits May 24, 2026 17:49

Update axmol/ui/Slider.cpp

b57dc9c

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update axmol/ui/LoadingBar.cpp

bd2d2f8

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update axmol/ui/ImageView.cpp

5322de5

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Fix reviews

f0ab497

Fix reviews

bdf64d3

gemini-code-assist Bot reviewed May 24, 2026

View reviewed changes

Comment thread axmol/platform/android/java/src/dev/axmol/lib/AxmolEngine.java

Comment thread axmol/ui/InputField.cpp Outdated

axmol-bot and others added 3 commits May 24, 2026 10:33

Committing clang-format changes

6296c0d

Fix reviews

0b039ae

Implement InputField editing with system menu for iOS

23f8372

axmol-bot and others added 2 commits May 24, 2026 12:50

Committing clang-format changes

680bfba

Update comment

dab517f

gemini-code-assist Bot reviewed May 24, 2026

View reviewed changes

Android system edit menu

2c1b43a

halx99 marked this pull request as draft May 25, 2026 23:45

halx99 added the breaking changes label May 27, 2026

Uh oh!

Conversation

halx99 commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Issue ticket number and link

Checklist before requesting a review

For each PR

For core/new feature PR

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

Uh oh!

halx99 commented May 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

halx99 commented May 20, 2026

Uh oh!

halx99 commented May 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

halx99 commented May 24, 2026

Uh oh!

halx99 commented May 24, 2026

Uh oh!

halx99 commented May 24, 2026

Uh oh!

halx99 commented May 24, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot commented May 24, 2026

Uh oh!

halx99 commented May 24, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

halx99 commented May 24, 2026

Uh oh!

halx99 commented May 24, 2026

Uh oh!

halx99 commented May 24, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 24, 2026

Choose a reason for hiding this comment

Uh oh!

halx99 commented May 19, 2026 •

edited

Loading