Add AX_DRAWNODE_FAST_LINE2CENTER to PhysicsDebugNode#3177
Draft
aismann wants to merge 3 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates DrawNode to support drawing solid circles with a customizable line color, adding new overloads of drawSolidCircle and updating PhysicsDebugNode to utilize them conditionally. The review feedback suggests cleaning up commented-out code, changing Vec2& parameters to const Vec2& across the new function signatures to allow passing temporary objects, and fixing a minor comment style issue (//// instead of //) in PhysicsDebugNode.cpp.
Contributor
Author
|
@halx99: |
Collaborator
Contributor
Author
|
@halx99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add AX_DRAWNODE_FAST_LINE2CENTER to PhysicsDebugNode
=>can be switched between the both DrawSolidCircle versions now.
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR