Support explicit secret scoping on custom jobs#2306
Open
shaanmajid wants to merge 4 commits into
Open
Conversation
shaanmajid
force-pushed
the
custom-job-secrets
branch
from
February 23, 2026 02:54
9278281 to
eeafa84
Compare
Author
|
This adds unknown-job-name validation for secrets (i.e. error on typos). The existing |
shaanmajid
force-pushed
the
custom-job-secrets
branch
from
April 7, 2026 10:35
eeafa84 to
6842f5f
Compare
Author
|
Hey @mistydemeo -- no rush, but just wanted to check if you're still open to this PR. If y'all don't have the bandwidth that's no problem-- I'll go ahead and close. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2282.
Summary
Adds
github-custom-job-secrets(v0) /secrets(v1) to scope which secrets are passed to custom CI jobs, replacing the blanketsecrets: inherit. Follows the pattern fromgithub-custom-job-permissions(#1179).secrets: inherit(preserving backwards compatibility)secrets:entirely["TOKEN"]) and map ({ TOKEN = "ORG_TOKEN" }) formats