fix(aeroshare): disable relays in LAN discovery and disclose the mDNS announce in the default mode

Two findings from the pre-tag commit audit of the LAN (mDNS) discovery feature. The lan mode promised "no internet and no relay" but RelayMode stayed Staging, so an online endpoint still registered its NodeId with the n0 relays; relays are now fully disabled in lan mode (same-subnet peers connect directly), taking precedence over custom relay URLs too. And the default "both" mode now folds in the local mDNS announce without saying so: the discovery label and description disclose it honestly in all 47 languages, so the informed-default contract from the v4.1.1 privacy work holds. Alongside, the same locale pass drops the two orphaned introHub keys left behind by the Add Service table refactor (dead code).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: axpnet

src-tauri/peer-l0/src/endpoint.rs

@@ -157,22 +157,30 @@ impl PeerEndpoint {
         // (`relay(http://localhost:3340)`), discovered purely via the Mainline DHT. This is what makes
         // the "every capable user runs their own relay" model work. The earlier "same relay set"
         // claim (from the WI-4g observation) was wrong; that failure had another cause.
-        let relay_mode = match cfg.custom_relay_urls.as_deref() {
-            Some(urls) if !urls.is_empty() => {
-                let parsed: Vec<iroh::RelayUrl> = urls
-                    .iter()
-                    .map(|u| {
-                        u.parse::<iroh::RelayUrl>()
-                            .with_context(|| format!("invalid custom relay URL: {u:?}"))
-                    })
-                    .collect::<Result<_>>()?;
-                info!(
-                    count = parsed.len(),
-                    "PeerEndpoint using RelayMode::Custom (self-hosted/override relays)"
-                );
-                iroh::RelayMode::Custom(iroh::RelayMap::from_iter(parsed))
+        // LAN-only discovery promises "local network, fully offline, no relay":
+        // honor it by disabling relays entirely (same-subnet peers connect
+        // directly, no hole punching needed), so no WAN service is ever
+        // contacted; this takes precedence over custom relay URLs too.
+        let relay_mode = if cfg.discovery == DiscoveryMode::Lan {
+            iroh::RelayMode::Disabled
+        } else {
+            match cfg.custom_relay_urls.as_deref() {
+                Some(urls) if !urls.is_empty() => {
+                    let parsed: Vec<iroh::RelayUrl> = urls
+                        .iter()
+                        .map(|u| {
+                            u.parse::<iroh::RelayUrl>()
+                                .with_context(|| format!("invalid custom relay URL: {u:?}"))
+                        })
+                        .collect::<Result<_>>()?;
+                    info!(
+                        count = parsed.len(),
+                        "PeerEndpoint using RelayMode::Custom (self-hosted/override relays)"
+                    );
+                    iroh::RelayMode::Custom(iroh::RelayMap::from_iter(parsed))
+                }
+                _ => iroh::RelayMode::Staging,
             }
-            _ => iroh::RelayMode::Staging,
         };
         // Register every ALPN the receive loop must accept: the L0 gate binary
         // dials with `PEER_L0_ALPN`, the app's "Send file" receive loop accepts
@@ -377,22 +385,27 @@ impl ConnectivitySample {
 /// No L0 ALPN is registered here; the L1 docs paths use a Router + blobs/gossip/docs ALPNs instead.
 /// This reuses the relay/discovery logic so L1 gets the same hole-punch behavior as the proven L0 stack.
 pub async fn build_base_endpoint(cfg: PeerEndpointConfig) -> Result<Endpoint> {
-    let relay_mode = match cfg.custom_relay_urls.as_deref() {
-        Some(urls) if !urls.is_empty() => {
-            let parsed: Vec<iroh::RelayUrl> = urls
-                .iter()
-                .map(|u| {
-                    u.parse::<iroh::RelayUrl>()
-                        .with_context(|| format!("invalid custom relay URL: {u:?}"))
-                })
-                .collect::<Result<_>>()?;
-            info!(
-                count = parsed.len(),
-                "build_base_endpoint (L1) using RelayMode::Custom (self-hosted/override relays)"
-            );
-            iroh::RelayMode::Custom(iroh::RelayMap::from_iter(parsed))
+    // Same LAN-only contract as PeerEndpoint::bind: no relay is ever contacted.
+    let relay_mode = if cfg.discovery == DiscoveryMode::Lan {
+        iroh::RelayMode::Disabled
+    } else {
+        match cfg.custom_relay_urls.as_deref() {
+            Some(urls) if !urls.is_empty() => {
+                let parsed: Vec<iroh::RelayUrl> = urls
+                    .iter()
+                    .map(|u| {
+                        u.parse::<iroh::RelayUrl>()
+                            .with_context(|| format!("invalid custom relay URL: {u:?}"))
+                    })
+                    .collect::<Result<_>>()?;
+                info!(
+                    count = parsed.len(),
+                    "build_base_endpoint (L1) using RelayMode::Custom (self-hosted/override relays)"
+                );
+                iroh::RelayMode::Custom(iroh::RelayMap::from_iter(parsed))
+            }
+            _ => iroh::RelayMode::Staging,
         }
-        _ => iroh::RelayMode::Staging,
     };
     let mut base = Endpoint::builder(iroh::endpoint::presets::Minimal).relay_mode(relay_mode);
     if let Some(seed) = cfg.identity_secret_key {

src/i18n/locales/bg.json

@@ -4418,10 +4418,6 @@
                 "failed": "Последният опит за свързване е неуспешен",
                 "lastFailedAt": "Последен неуспех преди {time}"
             },
-            "view": {
-                "grid": "Мрежа",
-                "list": "Списък"
-            },
             "check": "Провери",
             "scanning": "Сканиране...",
             "checkAvailability": "Провери наличността на услугата",
@@ -4442,8 +4438,7 @@
                 "customFtp": "FTP / FTPS",
                 "customSftp": "SFTP",
                 "customS3": "S3",
-                "customWebdav": "WebDAV",
-                "customAzure": "Azure Blob"
+                "customWebdav": "WebDAV"
             },
             "healthCheck": "Проверка на достъпност",
             "storageVersioning": "Версии на файлове: {size}",
@@ -5201,11 +5196,11 @@
                 "rateLimitUnit": "в минута",
                 "rateLimitOff": "Без ограничение на честотата (0): всеки сигнал е разрешен.",
                 "discoveryLabel": "Откриваемост",
-                "discovery_both": "n0 DNS + Mainline DHT (по подразбиране)",
+                "discovery_both": "n0 DNS + Mainline DHT + LAN mDNS (по подразбиране)",
                 "discovery_dht": "Само Mainline DHT",
                 "discovery_n0": "Само n0 DNS",
                 "discovery_none": "Без (не е откриваем)",
-                "discovery_both_desc": "Най-достъпен: докато приемате, адресът ви се публикува едновременно в директорията n0 и в публичния DHT.",
+                "discovery_both_desc": "Най-достъпен: докато приемате, адресът ви се публикува едновременно в директорията n0 и в публичния DHT, и се обявява в локалната ви мрежа чрез mDNS.",
                 "discovery_dht_desc": "Публикува се само в публичния Mainline DHT, без директорията n0.",
                 "discovery_n0_desc": "Публикува се само в директорията n0, без публичния DHT.",
                 "discovery_none_desc": "Вашият AeroFTP-ID не се публикува никъде, докато приемате, така че не може да бъде изброен в публичния DHT. Можете да бъдете достигнат само от някой, който вече разполага с пълния ви адрес (например чрез билет за устройство).",

src/i18n/locales/bn.json

@@ -4418,10 +4418,6 @@
                 "failed": "শেষ সংযোগের চেষ্টা ব্যর্থ হয়েছে",
                 "lastFailedAt": "শেষ ব্যর্থতা {time} আগে"
             },
-            "view": {
-                "grid": "গ্রিড",
-                "list": "তালিকা"
-            },
             "check": "যাচাই",
             "scanning": "স্ক্যান করা হচ্ছে...",
             "checkAvailability": "পরিষেবার উপলব্ধতা যাচাই করুন",
@@ -4442,8 +4438,7 @@
                 "customFtp": "FTP / FTPS",
                 "customSftp": "SFTP",
                 "customS3": "S3",
-                "customWebdav": "WebDAV",
-                "customAzure": "Azure Blob"
+                "customWebdav": "WebDAV"
             },
             "healthCheck": "হেলথ চেক",
             "storageVersioning": "ফাইল সংস্করণ: {size}",
@@ -5201,11 +5196,11 @@
                 "rateLimitUnit": "প্রতি মিনিটে",
                 "rateLimitOff": "কোনো হার সীমা নেই (0): প্রতিটি সংকেত অনুমোদিত।",
                 "discoveryLabel": "আবিষ্কারযোগ্যতা",
-                "discovery_both": "n0 DNS + Mainline DHT (ডিফল্ট)",
+                "discovery_both": "n0 DNS + Mainline DHT + LAN mDNS (ডিফল্ট)",
                 "discovery_dht": "শুধু Mainline DHT",
                 "discovery_n0": "শুধু n0 DNS",
                 "discovery_none": "কোনোটি নয় (আবিষ্কারযোগ্য নয়)",
-                "discovery_both_desc": "সর্বাধিক নাগালযোগ্য: গ্রহণ করার সময়, আপনার ঠিকানা n0 ডিরেক্টরি এবং সর্বজনীন DHT উভয়েই প্রকাশিত হয়।",
+                "discovery_both_desc": "সর্বাধিক নাগালযোগ্য: গ্রহণ করার সময়, আপনার ঠিকানা n0 ডিরেক্টরি এবং সর্বজনীন DHT উভয়েই প্রকাশিত হয়। এবং mDNS এর মাধ্যমে আপনার স্থানীয় নেটওয়ার্কে ঘোষণা করা হয়",
                 "discovery_dht_desc": "n0 ডিরেক্টরি ছাড়া শুধুমাত্র সর্বজনীন Mainline DHT-তে প্রকাশিত।",
                 "discovery_n0_desc": "সর্বজনীন DHT ছাড়া শুধুমাত্র n0 ডিরেক্টরিতে প্রকাশিত।",
                 "discovery_none_desc": "গ্রহণ করার সময় আপনার AeroFTP-ID কোথাও প্রকাশিত হয় না, তাই এটি সর্বজনীন DHT-তে গণনা করা যায় না। শুধুমাত্র এমন কেউ আপনার সাথে যোগাযোগ করতে পারবেন যিনি ইতিমধ্যে আপনার সম্পূর্ণ ঠিকানা ধারণ করেন (উদাহরণস্বরূপ একটি ড্রাইভ টিকিটের মাধ্যমে)।",

src/i18n/locales/ca.json

@@ -4437,10 +4437,6 @@
                 "failed": "L'últim intent de connexió ha fallat",
                 "lastFailedAt": "Últim error fa {time}"
             },
-            "view": {
-                "grid": "Quadrícula",
-                "list": "Llista"
-            },
             "check": "Comprova",
             "scanning": "Escanejant...",
             "checkAvailability": "Comprova la disponibilitat del servei",
@@ -4461,8 +4457,7 @@
                 "customFtp": "FTP / FTPS",
                 "customSftp": "SFTP",
                 "customS3": "S3",
-                "customWebdav": "WebDAV",
-                "customAzure": "Azure Blob"
+                "customWebdav": "WebDAV"
             },
             "healthCheck": "Comprovació de disponibilitat",
             "storageVersioning": "Versions del fitxer: {size}",
@@ -5220,11 +5215,11 @@
                 "rateLimitUnit": "per minut",
                 "rateLimitOff": "Sense límit de freqüència (0): es permet qualsevol senyal.",
                 "discoveryLabel": "Visibilitat",
-                "discovery_both": "n0 DNS + Mainline DHT (per defecte)",
+                "discovery_both": "n0 DNS + Mainline DHT + LAN mDNS (per defecte)",
                 "discovery_dht": "Només Mainline DHT",
                 "discovery_n0": "Només n0 DNS",
                 "discovery_none": "Cap (no visible)",
-                "discovery_both_desc": "Més accessible: mentre rebeu, la vostra adreça es publica tant al directori n0 com al DHT públic.",
+                "discovery_both_desc": "Més accessible: mentre rebeu, la vostra adreça es publica tant al directori n0 com al DHT públic, i s'anuncia a la vostra xarxa local mitjançant mDNS.",
                 "discovery_dht_desc": "Es publica només al Mainline DHT públic, sense el directori n0.",
                 "discovery_n0_desc": "Es publica només al directori n0, sense el DHT públic.",
                 "discovery_none_desc": "El vostre AeroFTP-ID no es publica enlloc mentre rebeu, de manera que no es pot enumerar al DHT públic. Només us pot contactar algú que ja tingui la vostra adreça completa (per exemple, mitjançant un tiquet d'unitat).",

src/i18n/locales/cs.json

@@ -4418,10 +4418,6 @@
                 "failed": "Poslední pokus o připojení selhal",
                 "lastFailedAt": "Poslední selhání před {time}"
             },
-            "view": {
-                "grid": "Mřížka",
-                "list": "Seznam"
-            },
             "check": "Zkontrolovat",
             "scanning": "Skenování...",
             "checkAvailability": "Zkontrolovat dostupnost služby",
@@ -4442,8 +4438,7 @@
                 "customFtp": "FTP / FTPS",
                 "customSftp": "SFTP",
                 "customS3": "S3",
-                "customWebdav": "WebDAV",
-                "customAzure": "Azure Blob"
+                "customWebdav": "WebDAV"
             },
             "healthCheck": "Kontrola dostupnosti",
             "storageVersioning": "Verze souborů: {size}",
@@ -5201,11 +5196,11 @@
                 "rateLimitUnit": "za minutu",
                 "rateLimitOff": "Bez limitu četnosti (0): povolen je každý signál.",
                 "discoveryLabel": "Viditelnost",
-                "discovery_both": "n0 DNS + Mainline DHT (výchozí)",
+                "discovery_both": "n0 DNS + Mainline DHT + LAN mDNS (výchozí)",
                 "discovery_dht": "Pouze Mainline DHT",
                 "discovery_n0": "Pouze n0 DNS",
                 "discovery_none": "Žádná (neviditelný)",
-                "discovery_both_desc": "Nejdostupnější: během příjmu je vaše adresa zveřejněna jak v adresáři n0, tak ve veřejném DHT.",
+                "discovery_both_desc": "Nejdostupnější: během příjmu je vaše adresa zveřejněna jak v adresáři n0, tak ve veřejném DHT a oznamována ve vaší místní síti přes mDNS.",
                 "discovery_dht_desc": "Zveřejněno pouze ve veřejném Mainline DHT, bez adresáře n0.",
                 "discovery_n0_desc": "Zveřejněno pouze v adresáři n0, bez veřejného DHT.",
                 "discovery_none_desc": "Vaše AeroFTP-ID není během příjmu nikde zveřejněno, takže jej nelze vyhledat ve veřejném DHT. Kontaktovat vás může pouze někdo, kdo již má vaši úplnou adresu (například prostřednictvím lístku jednotky).",

src/i18n/locales/cy.json

@@ -4437,10 +4437,6 @@
                 "failed": "Methodd y cais cysylltu diwethaf",
                 "lastFailedAt": "Methiant diwethaf {time} yn ôl"
             },
-            "view": {
-                "grid": "Grid",
-                "list": "Rhestr"
-            },
             "check": "Gwirio",
             "scanning": "Sganio...",
             "checkAvailability": "Gwirio argaeledd y gwasanaeth",
@@ -4461,8 +4457,7 @@
                 "customFtp": "FTP / FTPS",
                 "customSftp": "SFTP",
                 "customS3": "S3",
-                "customWebdav": "WebDAV",
-                "customAzure": "Azure Blob"
+                "customWebdav": "WebDAV"
             },
             "healthCheck": "Gwiriad iechyd",
             "storageVersioning": "Fersiynau ffeil: {size}",
@@ -5220,11 +5215,11 @@
                 "rateLimitUnit": "y funud",
                 "rateLimitOff": "Dim cyfyngiad cyfradd (0): caniateir pob signal.",
                 "discoveryLabel": "Darganfyddadwyedd",
-                "discovery_both": "n0 DNS + Mainline DHT (rhagosodedig)",
+                "discovery_both": "n0 DNS + Mainline DHT + LAN mDNS (rhagosodedig)",
                 "discovery_dht": "Mainline DHT yn unig",
                 "discovery_n0": "n0 DNS yn unig",
                 "discovery_none": "Dim (ddim yn ddarganfyddadwy)",
-                "discovery_both_desc": "Mwyaf cyraeddadwy: wrth dderbyn, mae eich cyfeiriad yn cael ei gyhoeddi i'r cyfeiriadur n0 a'r DHT cyhoeddus.",
+                "discovery_both_desc": "Mwyaf cyraeddadwy: wrth dderbyn, mae eich cyfeiriad yn cael ei gyhoeddi i'r cyfeiriadur n0 a'r DHT cyhoeddus ac yn cael ei ddatgan ar eich rhwydwaith lleol dros mDNS.",
                 "discovery_dht_desc": "Cyhoeddwyd i'r Mainline DHT cyhoeddus yn unig, heb y cyfeiriadur n0.",
                 "discovery_n0_desc": "Cyhoeddwyd i'r cyfeiriadur n0 yn unig, heb y DHT cyhoeddus.",
                 "discovery_none_desc": "Nid yw eich AeroFTP-ID yn cael ei gyhoeddi yn unman wrth dderbyn, felly ni ellir ei restru ar y DHT cyhoeddus. Dim ond rhywun sydd eisoes â'ch cyfeiriad llawn all gysylltu â chi (er enghraifft trwy docyn gyrru).",

src/i18n/locales/da.json

@@ -4418,10 +4418,6 @@
                 "failed": "Sidste forbindelsesforsøg mislykkedes",
                 "lastFailedAt": "Seneste fejl for {time} siden"
             },
-            "view": {
-                "grid": "Gitter",
-                "list": "Liste"
-            },
             "check": "Tjek",
             "scanning": "Scanner...",
             "checkAvailability": "Tjek tjenestens tilgængelighed",
@@ -4442,8 +4438,7 @@
                 "customFtp": "FTP / FTPS",
                 "customSftp": "SFTP",
                 "customS3": "S3",
-                "customWebdav": "WebDAV",
-                "customAzure": "Azure Blob"
+                "customWebdav": "WebDAV"
             },
             "healthCheck": "Tilgængelighedstjek",
             "storageVersioning": "Filversioner: {size}",
@@ -5201,11 +5196,11 @@
                 "rateLimitUnit": "pr. minut",
                 "rateLimitOff": "Ingen hastighedsgrænse (0): alle signaler tillades.",
                 "discoveryLabel": "Synlighed",
-                "discovery_both": "n0 DNS + Mainline DHT (standard)",
+                "discovery_both": "n0 DNS + Mainline DHT + LAN mDNS (standard)",
                 "discovery_dht": "Kun Mainline DHT",
                 "discovery_n0": "Kun n0 DNS",
                 "discovery_none": "Ingen (ikke synlig)",
-                "discovery_both_desc": "Mest tilgængelig: mens du modtager, offentliggøres din adresse både i n0-mappen og i det offentlige DHT.",
+                "discovery_both_desc": "Mest tilgængelig: mens du modtager, offentliggøres din adresse både i n0-mappen og i det offentlige DHT og annonceres på dit lokale netværk via mDNS.",
                 "discovery_dht_desc": "Offentliggøres kun i det offentlige Mainline DHT, uden n0-mappen.",
                 "discovery_n0_desc": "Offentliggøres kun i n0-mappen, uden det offentlige DHT.",
                 "discovery_none_desc": "Dit AeroFTP-ID offentliggøres ingen steder, mens du modtager, så det kan ikke opregnes i det offentlige DHT. Du kan kun nås af nogen, der allerede har din fulde adresse (for eksempel via en drevbillet).",