Commit f43120a
chore(deps): bump actions/upload-artifact from 4 to 5 (#508)
* Fix: Apply absolute value logic in `PluralRules` (#506)
This PR addresses a long-standing inconsistency in the pluralization logic used by `PluralRules`.
Previously, the implementation did not explicitly evaluate the absolute value of the input number, contrary to the CLDR specification.
This led to incorrect plural category resolution for negative numbers, which typically defaulted to the `OTHER` category.
#### Changes
- The decimal argument passed to all `PluralRules` delegates is now transformed to its absolute value before evaluation.
- This change ensures that plural category resolution aligns with CLDR expectations, particularly because locales with plural forms depend on numeric value regardless of sign.
#### Impact
- Fixes incorrect plural category resolution for negative numbers in locales such as `DualOneOther`, where the number of plural word variants influences the outcome.
- May affect pluralization behavior in edge cases across multiple locales. Unit tests have been updated to reflect the corrected logic.
- The change affects `PluralLocalizationFormatter` and `TimeFormatter`.
- **Thoroughly test the new version in your localization workflows**, especially if you rely on custom pluralization delegates or locale-specific plural form resolution. This change may surface previously masked edge cases.
#### Versioning
- The PR will be published with a new **minor version**, as this change corrects a bug but may alter behavior in downstream formatting logic.
#### Background
See discussion in #503 and #497 for context.
* chore(deps): bump actions/upload-artifact from 4 to 5
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4...v5)
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-version: '5'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* Fix error in Demo project
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: axunonb <axunonb@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>1 parent 040f236 commit f43120a
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
| 193 | + | |
193 | 194 | | |
194 | | - | |
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
0 commit comments