Added implementation of Not_Equal_To#29
Open
mangodo100 wants to merge 1 commit into
Open
Conversation
|
Fix #28 |
ayaankhan98
reviewed
Oct 5, 2020
Owner
ayaankhan98
left a comment
ayaankhan98
left a comment
There was a problem hiding this comment.
This looks fine to me
can you implement the possible overloads of != operator along with the tests
Author
|
yeah sure |
ufrshubham
reviewed
Oct 8, 2020
Comment on lines
+35
to
+48
| bool largeInt:: operator != (const largeInt& z) { | ||
| if(this->sign != z.sign) { | ||
| return true; | ||
| } | ||
| if (this->number.length() != z.number.length()) { | ||
| return true; | ||
| } | ||
| for(int i = 0; i < this->number.length(); i++) { | ||
| if (this->number[i] != z.number[i]) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Why does this have to be so complex? Operator == is already overloaded.
bool largeInt:: operator != (const largeInt z) {
return !(*this == z);
}
This much code should be fine. Plus it will always be in sync with == operator.
Owner
There was a problem hiding this comment.
actually this PR was made before the overloading of == operator.
i was thiking to request changes on this
thanks @ufrshubham for pointing out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.