fix(review): finalize WAL on smoke-test failure path too (round3-minor)

Author: ayhammouda

src/mcp_server_python_docs/ingestion/publish.py

@@ -353,6 +353,9 @@ def publish_index(
                 ("failed", "\n".join(messages), run_id),
             )
             conn.commit()
+            # Round 3: finalize WAL here too so the failed build_db leaves no
+            # -wal/-shm sidecars even though we're not swapping it in.
+            finalize_for_swap(conn)
             logger.error("Smoke tests failed — not publishing")
             return False
 

tests/test_publish.py

@@ -332,6 +332,56 @@ def test_publish_index_second_build_replaces_cleanly(self, tmp_path, monkeypatch
         assert not wal_sidecars, f"WAL sidecar leaked after 2nd build: {entries}"
         assert not shm_sidecars, f"SHM sidecar leaked after 2nd build: {entries}"
 
+    def test_publish_index_leaves_no_wal_sidecars_on_smoke_failure(
+        self, tmp_path, monkeypatch
+    ):
+        """Round 3: smoke-test failure path must also finalize WAL.
+
+        Forces run_smoke_tests to return (False, [...]) and asserts publish_index
+        returns False AND leaves no -wal/-shm sidecars in the cache dir.
+        """
+        from mcp_server_python_docs.ingestion import publish as publish_mod
+
+        target_index = tmp_path / "index.db"
+        monkeypatch.setattr(
+            "mcp_server_python_docs.storage.db.get_cache_dir",
+            lambda: tmp_path,
+        )
+        monkeypatch.setattr(
+            "mcp_server_python_docs.storage.db.get_index_path",
+            lambda: target_index,
+        )
+        monkeypatch.setattr(publish_mod, "get_index_path", lambda: target_index)
+
+        # Force smoke test failure regardless of DB contents.
+        monkeypatch.setattr(
+            publish_mod,
+            "run_smoke_tests",
+            lambda *args, **kwargs: (False, ["FAIL: forced for test"]),
+        )
+
+        build_db = tmp_path / "build-smoke-fail.db"
+        self._seed_passing_build(build_db)
+
+        assert publish_mod.publish_index(build_db, "3.13") is False
+
+        # No WAL/SHM sidecars anywhere in tmp_path.
+        wal_sidecars = [
+            p.name for p in tmp_path.iterdir() if p.name.endswith("-wal")
+        ]
+        shm_sidecars = [
+            p.name for p in tmp_path.iterdir() if p.name.endswith("-shm")
+        ]
+        assert not wal_sidecars, (
+            f"WAL sidecar leaked on failure path: {wal_sidecars}"
+        )
+        assert not shm_sidecars, (
+            f"SHM sidecar leaked on failure path: {shm_sidecars}"
+        )
+
+        # index.db must not have been created (atomic_swap was not reached).
+        assert not target_index.exists()
+
 
 class TestReadOnlyConnection:
     def test_can_query_existing_db(self, tmp_path):