Skip to content

send pre_save and post_save signals before and after bulk_update#74

Open
renskiy wants to merge 2 commits into
aykut:masterfrom
renskiy:pre-save-post-save-signals
Open

send pre_save and post_save signals before and after bulk_update#74
renskiy wants to merge 2 commits into
aykut:masterfrom
renskiy:pre-save-post-save-signals

Conversation

@renskiy
Copy link
Copy Markdown

@renskiy renskiy commented Jul 19, 2018

I think this should be nice feature

@itimky
Copy link
Copy Markdown

itimky commented Oct 20, 2018

It's a great feature, but It could break backwards compatibility. I think it should be optional.

@ulgens
Copy link
Copy Markdown

ulgens commented Nov 12, 2018

Django's bulk_create emit those signals and i don't think it should be implemented here.

https://docs.djangoproject.com/en/2.1/ref/models/querysets/#bulk-create

@renskiy
Copy link
Copy Markdown
Author

renskiy commented Nov 13, 2018

As @itimky said, this can be done optionally. Moreover there is default implementation of bulk_update out of the box already: in django 2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants