Add example of how to prefetch ssr data#5
Open
agungsb wants to merge 2 commits into
Open
Conversation
added 2 commits
June 11, 2017 00:45
Owner
|
Hey, I'm gonna be honest, there's ALOT of code here to do something really simple?
Code:
Okay, this is taking me too much time, you've made a lot of changes that I feel could simply be done with: action.set({start: true})
fetch(url)
.then(v=>action.set({page: v}))
.catch(error=>action.set({error})Can you justify your changes? |
|
Would love to have this feature well integrated 😍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add an example on how to prefetch ssr data as described here.
I also add
clientMiddleware.jsandApiClient.jsso it's possible to make a call request insideredux actions(the source code is from this awesome boilerplate).