Add logic to allow warnings for input fields#3256
Conversation
…arent" This reverts commit f6a29cd.
|
Build failing |
|
@FrancescoBorzi Works on my end. Can you please provide more information ? |
|
We have a lint rule that notifies if a component is not using the OnPush strategy, it's complaining about it |
|
Thank you, but the failed test is intentional. |
|
ok, I will test this PR locally and let you know ;-) |
|
Thank you :) |
|
I also would like to mention, that this will NOT address any editors. The example I added for the maxLevel in creature template is just for showcasing purposes of the proposed solution. The PR aims to provide an easy framework to add form validation, not to add form validation everywhere it is needed. This needs to happen gradually, otherwise this will be a gigantic PR, considering Item Template and Creature Template have to change along with a lot of other forms. |
|
I don't dislike the approach but I am wondering if can be done only with: <input
keiraInputValidation
[formControlName]="'maxlevel'"
id="maxlevel"
type="number"
class="form-control form-control-sm"
/>Without requiring any other information or adding components, because may you can find a way to get the formcontrol from the input and you could spawn dynamically a component next to the without already writing a placeholder component Thanks by the way for implementing this proof of concept of warnings, it's a good job! |
|
Thank you for providing feedback. I will try to make it work. I also had a solution in mind that minimizes the changes required to all editors as this can introduce quite the overhead in work. I will explore possible solutions and hopefully something will work :) |
|
In theory I could do something like this: import { Directive, ViewContainerRef } from '@angular/core';
@Directive({
selector: '[dynamicComponentHost]',
})
export class DynamicComponentHostDirective {
constructor(public viewContainerRef: ViewContainerRef) {}
}import { Component, ComponentFactoryResolver, OnInit } from '@angular/core';
import { KeiraValidationFeedbackComponent } from './keira-validation-feedback.component';
import { DynamicComponentHostDirective } from './dynamic-component-host.directive';
@Component({
selector: 'app-dynamic-form',
template: `
<div class="form-group col-12 col-sm-6 col-md-4 col-lg-3 col-xl-2">
<label for="maxLevel">Max Level</label>
<input
[keiraInputValidation]="editorService.form.get('maxlevel')"
[formControlName]="'maxlevel'"
id="maxlevel"
type="number"
class="form-control form-control-sm"
(blur)="showValidationFeedback()"
/>
<ng-template dynamicComponentHost></ng-template>
</div>
`,
})
export class DynamicFormComponent implements OnInit {
@ViewChild(DynamicComponentHostDirective, { static: true })
dynamicHost!: DynamicComponentHostDirective;
constructor(
private resolver: ComponentFactoryResolver,
public editorService: EditorService
) {}
ngOnInit(): void {}
showValidationFeedback(): void {
const control = this.editorService.form.get('maxlevel');
if (control?.invalid && control.touched) {
const viewContainerRef = this.dynamicHost.viewContainerRef;
viewContainerRef.clear(); // Clear any existing components
const componentFactory =
this.resolver.resolveComponentFactory(KeiraValidationFeedbackComponent);
const componentRef = viewContainerRef.createComponent(componentFactory);
componentRef.instance.control = control; // Pass the control to the component
}
}
}Used like this: <div class="form-group col-12 col-sm-6 col-md-4 col-lg-3 col-xl-2">
<label for="maxLevel">Max Level</label>
<input
[keiraInputValidation]="editorService.form.get('maxlevel')"
[formControlName]="'maxlevel'"
id="maxlevel"
type="number"
class="form-control form-control-sm"
(blur)="showValidationFeedback()"
/>
<ng-template dynamicComponentHost></ng-template>
</div>But personally, I think this is a lot of boilerplate code and super convoluted too, for a worse outcome in terms of readability and most likely maintainability too. If you have a better solution or something I should check out, please let me know :) |
|
I was convinced that everything can be implemented inside the directive attribute making it agnostic and generic for all inputs without requiring any input information. import { Directive, ElementRef, inject, OnInit, Renderer2 } from '@angular/core';
import { AbstractControl, NgControl } from '@angular/forms';
import { SubscriptionHandler } from '@keira/shared/utils';
@Directive({
selector: '[keiraInputValidation]',
standalone: true,
})
export class InputValidationDirective extends SubscriptionHandler implements OnInit {
private readonly el: ElementRef = inject(ElementRef);
private readonly renderer: Renderer2 = inject(Renderer2);
private readonly ngControl: NgControl = inject(NgControl);
private errorDiv: HTMLElement | null = null;
ngOnInit(): void {
const control = this.ngControl.control;
if (!control) {
return;
}
this.subscriptions.push(
control.statusChanges?.subscribe(() => {
this.updateErrorMessage(control);
}),
);
}
private updateErrorMessage(control: AbstractControl): void {
if (this.errorDiv) {
this.renderer.removeChild(this.el.nativeElement.parentNode, this.errorDiv);
this.errorDiv = null;
}
if (control?.touched && control?.invalid) {
const errorMessage = control?.errors?.['required'] ? 'This field is required' : 'Invalid field';
this.errorDiv = this.renderer.createElement('div');
const text = this.renderer.createText(errorMessage);
this.renderer.appendChild(this.errorDiv, text);
const parent = this.el.nativeElement.parentNode;
this.renderer.appendChild(parent, this.errorDiv);
}
}
}<div class="form-group col-12 col-sm-6 col-md-4 col-lg-3 col-xl-2">
<label for="maxLevel">Max Level</label>
<input keiraInputValidation [formControlName]="'maxlevel'" id="maxlevel" type="number" class="form-control form-control-sm" />
</div>This will allow us to add the directive You can find the commit here 7021a3a 
EDIT: this code is a draft based on your code, you can re-use it improving it if possible, we could continue the implementation in this branch/PR |
|
@Helias |
Co-Authored-By: Stefano Borzì <stefanoborzi32@gmail.com>
|
@Helias Additionally, if we add the validation, we are just one step shy of adding a subject that the keira edit button can subscribe to, to disable them if validation fails. |
|
I noticed that, if we remove the control.touched contidion it should work on the first time too, I am not sure if it's 100% correct but we could remove it and then think if we really need that condition or not. About the validation, that's a good idea actually 🚀 |
|
I added a workaround, by adding markedAsTouched() when the field is invalid. But maybe thats not as good as a solution as it can be? |
it could be in this case, let's keep it |
| for (const k of Object.keys(this._form.controls)) { | ||
| console.log(k); | ||
| } | ||
| } |
There was a problem hiding this comment.
not sure about this code inside the else block, it seems more a debug code , we could keep it, but could you give me more insight about it?
There was a problem hiding this comment.
@Exitare please do not mark comments as resolved without answering or addressing them
There was a problem hiding this comment.
I resolved it, because I removed it initially. But then one of the tests failed and I added it back, but didn't unresolve the issue here.
| const parent = this.el.nativeElement.parentNode; | ||
| if (parent) { | ||
| this.errorDiv = this.renderer.createElement('div'); | ||
| this.renderer.addClass(this.errorDiv, 'error-message'); |
There was a problem hiding this comment.
I think that I wrote this, but I am not sure if we have a class error-message, if not, we could remove this line of code
There was a problem hiding this comment.
We dont. But the tests use it to get the div in order to verify the correct message.
There was a problem hiding this comment.
I would use an id instead of a class for this
| RouterLink, | ||
| InputValidationDirective, | ||
| ], | ||
| providers: [ValidationService], |
There was a problem hiding this comment.
why does it have to be a singleton?
There was a problem hiding this comment.
Because validation should happen on a page by page basis and not on the app level ?
There was a problem hiding this comment.
It should not be necessary, we could keep one instance for the entire application, so provide it in "root" and don't put it here.
If you find a strong reason to provide it inside the component then we could put it back.
| const defaultValue = defaultValues[field]; | ||
| this._form.addControl(field, new FormControl(defaultValue, [Validators.required])); |
There was a problem hiding this comment.
| const defaultValue = defaultValues[field]; | |
| this._form.addControl(field, new FormControl(defaultValue, [Validators.required])); | |
| this._form.addControl(field, new FormControl(defaultValues[field], [Validators.required])); |
|
|
||
| this._form = new FormGroup<ModelForm<T>>({} as any); | ||
|
|
||
| // Loop through the fields and initialize controls with default values |
There was a problem hiding this comment.
I don't think we need this comment, IMHO the code seems already quite self-explanatory :)
| // Loop through the fields and initialize controls with default values |
| if (typeof field === 'string') { | ||
| const control = this._form.controls[field]; |
There was a problem hiding this comment.
is this change needed for the original purpose of the PR? in general, I'd prefer to split changes in several PRs, for example:
- 1 PR to include new functionality (including its unit tests)
- a separate PR to improve/refactor existing code that is not related to the functionality being introduced
| class="btn btn-primary btn-sm" | ||
| (click)="execute()" | ||
| id="execute-btn" | ||
| [disabled]="(validationService.validationPassed$ | async) === false" |
There was a problem hiding this comment.
I think we should avoid this repetition and wrap validationService.validationPassed$ in a variable. Even better to use a Signal.
There was a problem hiding this comment.
I don't know how this requested change should look like because I used a variable before and it was requested to use the async pipe. Now it's back to variable again?
There was a problem hiding this comment.
Before it was a variable with a subscription running on ngOninit, this affects the component adding a dependency for the OnInit interface and moreover, it forces you to manage the subscribe/unsubscribe.
In the current situation you don't need ngOninit and to manage the subscribe/unsubscribe thanks to the async pipe.
Wrapping this into a variable can be done without ngOninit still and in the following way:
protected readonly isValidationPassed$ = this.validationService.validationPassed$.pipe(map((val) => val === false));Keeping in the template
[disabled]="isValidationPassed$ | async"Or, you could use signals
There was a problem hiding this comment.
OK, for learning purposes. What's the undesirable part about having a dependency in the ngOnInit, besides the subscription management part. Is it a general best practice not to use the ngOnInit if possible?
There was a problem hiding this comment.
Personally I avoid any kind of dependencies, so if we can avoid ngOnInit, ngOnChanges etc. in an elegant way I would not add them because It increases the complexity of the logic component
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "name": "keira-shared-directives", | |||
There was a problem hiding this comment.
I think it's better to create a lib for validation instead of creating one lib for "directives" that can contain several directives that are unrelated to them.
So in the validation lib you can have all generic tools that are being used for the validation, including the validation service.
There was a problem hiding this comment.
Interesting approach. I placed the files in the respective libs as this is done with several other functionalities too. There is no lib sql service either and so on. They are all pretty generic.
|
@Exitare are you planning to complete this? |
|
Yes, I plan to. I will be able to spend more time on the project again in around 2 months. If thats too long, I am fine with closing the PR. |
no worries, we will wait for you! |
📝 WalkthroughWalkthroughAdds shared form validation tracking and error rendering, applies required validation to editor forms, improves reload handling, and updates creature-template inputs with validation plus navigation to the creature model editor. ChangesValidation and editor behavior
Creature template UI
Test assertion maintenance
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant InputValidationDirective
participant ValidationService
participant EditorForm
User->>EditorForm: edit required field
EditorForm->>InputValidationDirective: update control status
InputValidationDirective->>ValidationService: set control validity
InputValidationDirective->>EditorForm: render validation message
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
libs/shared/directives/src/index.tsOops! Something went wrong! :( ESLint: 8.57.1 Error: Error while loading rule ' libs/shared/directives/src/validate-input.directive.spec.tsOops! Something went wrong! :( ESLint: 8.57.1 Error: Error while loading rule ' libs/shared/directives/src/validate-input.directive.tsOops! Something went wrong! :( ESLint: 8.57.1 Error: Error while loading rule ' Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
libs/features/creature/src/creature-template/creature-template.component.html (1)
188-191: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove empty
href=""attribute.Angular's
routerLinkdirective automatically generates and manages thehrefattribute for<a>tags. Providing an explicit emptyhref=""is redundant and can occasionally cause unintended page reloads or routing issues if event propagation is not perfectly intercepted.♻️ Proposed fix
<span >Models are now available in the - <a href="" [routerLink]="['/creature', 'creature-template-model']">Creature Template Model</a> editor.</span + <a [routerLink]="['/creature', 'creature-template-model']">Creature Template Model</a> editor.</span >🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@libs/features/creature/src/creature-template/creature-template.component.html` around lines 188 - 191, Remove the empty href attribute from the anchor using the routerLink directive in the template, leaving the existing routerLink target and link text unchanged.libs/shared/common-services/src/validation.service.ts (1)
8-16: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueAvoid using
anyfor map keys.Consider replacing
anywithunknownfor thecontrolparameter and the map key to improve type safety. Since the parameter is only used as a reference key in theMap,unknownis sufficient and safer thanany.♻️ Proposed refactor
- private readonly controlsValidityMap = new Map<any, boolean>(); + private readonly controlsValidityMap = new Map<unknown, boolean>(); readonly validationPassed$: BehaviorSubject<boolean> = new BehaviorSubject(true); - setControlValidity(control: any, isValid: boolean): void { + setControlValidity(control: unknown, isValid: boolean): void { this.controlsValidityMap.set(control, isValid); this.updateValidationState(); } - removeControl(control: any): void { + removeControl(control: unknown): void {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@libs/shared/common-services/src/validation.service.ts` around lines 8 - 16, Replace any with unknown for the controlsValidityMap key type and the control parameters in setControlValidity and removeControl. Keep the existing map-key reference behavior and validation-state updates unchanged.libs/shared/directives/src/validate-input.directive.ts (1)
36-39: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove the error element from the DOM on destroy.
If the input element is destroyed (e.g., via
*ngIf) but its parent container remains, the dynamically appended error messagedivwill be left orphaned in the DOM. It is recommended to clean it up inngOnDestroy.♻️ Proposed refactor
override ngOnDestroy(): void { + if (this.errorDiv) { + this.renderer.removeChild(this.el.nativeElement.parentNode, this.errorDiv); + this.errorDiv = null; + } this.validationService.removeControl(this); super.ngOnDestroy(); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@libs/shared/directives/src/validate-input.directive.ts` around lines 36 - 39, Update ValidateInputDirective.ngOnDestroy to remove the dynamically appended error-message div from the DOM before or alongside removing the control from validationService. Reuse the directive’s existing reference to that element, guard cleanup when it is absent, and preserve the superclass destruction call.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@libs/features/creature/src/creature-template/creature-template.component.html`:
- Around line 50-51: Update the label associated with the maxlevel form control
so its for attribute exactly matches the input id, preserving the existing
maxlevel control binding and markup.
In `@libs/shared/directives/project.json`:
- Around line 9-19: The shared directives unit-test setup still uses Karma
instead of the required Vitest configuration. Update the test target in
libs/shared/directives/project.json (lines 9-19) to use the workspace-approved
Vitest executor and options, delete the obsolete Karma configuration in
libs/shared/directives/karma.conf.js (lines 1-15), and remove "jasmine" from the
types array in libs/shared/directives/tsconfig.spec.json (lines 4-6).
In `@tsconfig.base.json`:
- Around line 61-64: Remove the invalid "texts" path alias from the tsconfig
paths configuration; retain the existing "`@keira/features/texts`" alias and all
other mappings unchanged.
---
Nitpick comments:
In
`@libs/features/creature/src/creature-template/creature-template.component.html`:
- Around line 188-191: Remove the empty href attribute from the anchor using the
routerLink directive in the template, leaving the existing routerLink target and
link text unchanged.
In `@libs/shared/common-services/src/validation.service.ts`:
- Around line 8-16: Replace any with unknown for the controlsValidityMap key
type and the control parameters in setControlValidity and removeControl. Keep
the existing map-key reference behavior and validation-state updates unchanged.
In `@libs/shared/directives/src/validate-input.directive.ts`:
- Around line 36-39: Update ValidateInputDirective.ngOnDestroy to remove the
dynamically appended error-message div from the DOM before or alongside removing
the control from validationService. Reuse the directive’s existing reference to
that element, guard cleanup when it is absent, and preserve the superclass
destruction call.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 22c08172-2d78-4237-a3d3-be89e28f8bb0
📒 Files selected for processing (23)
apps/keira/src/app/scss/_editor.scsslibs/features/creature/src/creature-template/creature-template.component.htmllibs/features/creature/src/creature-template/creature-template.component.tslibs/features/quest/src/quest-preview/quest-preview.service.spec.tslibs/shared/base-abstract-classes/src/service/editors/editor.service.spec.tslibs/shared/base-abstract-classes/src/service/editors/editor.service.tslibs/shared/base-abstract-classes/src/service/editors/single-row-editor.service.spec.tslibs/shared/base-abstract-classes/src/service/editors/single-row-editor.service.tslibs/shared/base-editor-components/src/query-output/query-output.component.tslibs/shared/common-services/src/index.tslibs/shared/common-services/src/validation.service.spec.tslibs/shared/common-services/src/validation.service.tslibs/shared/directives/.eslintrc.jsonlibs/shared/directives/README.mdlibs/shared/directives/karma.conf.jslibs/shared/directives/project.jsonlibs/shared/directives/src/index.tslibs/shared/directives/src/validate-input.directive.spec.tslibs/shared/directives/src/validate-input.directive.tslibs/shared/directives/tsconfig.jsonlibs/shared/directives/tsconfig.lib.jsonlibs/shared/directives/tsconfig.spec.jsontsconfig.base.json
💤 Files with no reviewable changes (1)
- libs/shared/base-abstract-classes/src/service/editors/editor.service.spec.ts
| <label for="maxLevel">maxlevel</label> | ||
| <input keiraInputValidation [formControlName]="'maxlevel'" id="maxlevel" type="number" class="form-control form-control-sm" /> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Match the for attribute with the input id.
The for attribute on the label (maxLevel) does not match the id of the input (maxlevel). HTML id attributes are case-sensitive, so clicking the label will not focus the input.
🐛 Proposed fix
- <label for="maxLevel">maxlevel</label>
+ <label for="maxlevel">maxlevel</label>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <label for="maxLevel">maxlevel</label> | |
| <input keiraInputValidation [formControlName]="'maxlevel'" id="maxlevel" type="number" class="form-control form-control-sm" /> | |
| <label for="maxlevel">maxlevel</label> | |
| <input keiraInputValidation [formControlName]="'maxlevel'" id="maxlevel" type="number" class="form-control form-control-sm" /> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@libs/features/creature/src/creature-template/creature-template.component.html`
around lines 50 - 51, Update the label associated with the maxlevel form control
so its for attribute exactly matches the input id, preserving the existing
maxlevel control binding and markup.
| "test": { | ||
| "executor": "@angular-devkit/build-angular:karma", | ||
| "options": { | ||
| "tsConfig": "libs/shared/directives/tsconfig.spec.json", | ||
| "karmaConfig": "libs/shared/directives/karma.conf.js", | ||
| "polyfills": ["zone.js", "zone.js/testing"], | ||
| "sourceMap": true, | ||
| "codeCoverage": true, | ||
| "scripts": [] | ||
| } | ||
| }, |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Configure Vitest for unit tests instead of Karma.
This library was generated using the default Karma test runner, but the project guidelines mandate Vitest for all unit tests. Please migrate the library's test configuration to use Vitest to ensure consistency across the workspace.
libs/shared/directives/project.json#L9-L19: Update thetesttarget to use the Vitest executor (e.g.,@nx/vite:testor@analogjs/vite-plugin-angular).libs/shared/directives/karma.conf.js#L1-L15: Delete this Karma configuration file as it is no longer needed.libs/shared/directives/tsconfig.spec.json#L4-L6: Remove"jasmine"from thetypesarray, as Vitest uses its own typings.
📍 Affects 3 files
libs/shared/directives/project.json#L9-L19(this comment)libs/shared/directives/karma.conf.js#L1-L15libs/shared/directives/tsconfig.spec.json#L4-L6
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@libs/shared/directives/project.json` around lines 9 - 19, The shared
directives unit-test setup still uses Karma instead of the required Vitest
configuration. Update the test target in libs/shared/directives/project.json
(lines 9-19) to use the workspace-approved Vitest executor and options, delete
the obsolete Karma configuration in libs/shared/directives/karma.conf.js (lines
1-15), and remove "jasmine" from the types array in
libs/shared/directives/tsconfig.spec.json (lines 4-6).
Source: Coding guidelines
| "@keira/shared/utils": ["libs/shared/utils/src/index.ts"], | ||
| "@keira/shared/directives": ["libs/shared/directives/src/index.ts"], | ||
| "@keira/shared/error-templates": ["libs/shared/error-templates/src/index.ts"], | ||
| "texts": ["libs/features/texts/src/index.ts"] |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the invalid path alias.
The path alias "texts" violates the naming guideline, which requires @keira/<scope>/<name>. Furthermore, the correct alias "@keira/features/texts" is already defined earlier in this file.
🐛 Proposed fix
"`@keira/shared/utils`": ["libs/shared/utils/src/index.ts"],
"`@keira/shared/directives`": ["libs/shared/directives/src/index.ts"],
- "`@keira/shared/error-templates`": ["libs/shared/error-templates/src/index.ts"],
- "texts": ["libs/features/texts/src/index.ts"]
+ "`@keira/shared/error-templates`": ["libs/shared/error-templates/src/index.ts"]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@keira/shared/utils": ["libs/shared/utils/src/index.ts"], | |
| "@keira/shared/directives": ["libs/shared/directives/src/index.ts"], | |
| "@keira/shared/error-templates": ["libs/shared/error-templates/src/index.ts"], | |
| "texts": ["libs/features/texts/src/index.ts"] | |
| "`@keira/shared/utils`": ["libs/shared/utils/src/index.ts"], | |
| "`@keira/shared/directives`": ["libs/shared/directives/src/index.ts"], | |
| "`@keira/shared/error-templates`": ["libs/shared/error-templates/src/index.ts"] |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@tsconfig.base.json` around lines 61 - 64, Remove the invalid "texts" path
alias from the tsconfig paths configuration; retain the existing
"`@keira/features/texts`" alias and all other mappings unchanged.
Source: Coding guidelines
4 participants
Does address but does not close #3236.
Tests are failing, because I dont want to fix them before this idea is either accepted or denied.
Right now, this is only working for the creature template max level field.
Feedback is welcome
Summary by CodeRabbit
New Features
Bug Fixes