Skip to content

fix(sai-editor): update tooltips SET_INST_DATA and SET_INST_DATA64#3745

Merged
Helias merged 1 commit into
azerothcore:masterfrom
sogladev:fix-actions-instance-data
May 6, 2026
Merged

fix(sai-editor): update tooltips SET_INST_DATA and SET_INST_DATA64#3745
Helias merged 1 commit into
azerothcore:masterfrom
sogladev:fix-actions-instance-data

Conversation

@sogladev
Copy link
Copy Markdown
Member

@sogladev sogladev commented May 3, 2026

  • Add tooltips for set inst params
  • Add description and tooltip for param3 type
  • Change comment generator to include SetBossState with respective states, e.g, DONE
  • Remove param2 for inst_data_64 as it's not used

See SMART_ACTION_SET_INST_DATA https://www.azerothcore.org/wiki/smart_scripts or summary here:

  • C++ structs
struct
{
    uint32 field;
    uint32 data;
    uint32 type;
} setInstanceData;

struct
{
    uint32 field;
} setInstanceData64;
  • setInstanceData

    • Action parameter mapping:

      • action_param1 -> field (uint32)
      • action_param2 -> data (uint32)
      • action_param3 -> type (uint32) // used for SetData / SetBossState
    • Meaning of type:

      • 0 = call InstanceScript::SetData(field, data)
      • 1 = call InstanceScript::SetBossState(field, static_cast<EncounterState>(data))
  • setInstanceData64

    • Action parameter mapping:
      • action_param1 -> field (uint32)

@Helias Helias merged commit 0a11b98 into azerothcore:master May 6, 2026
12 checks passed
@Helias
Copy link
Copy Markdown
Member

Helias commented May 6, 2026

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants