Skip to content

feat: more trading infos by parsing more from trading summary endpoint#57

Merged
azerpas merged 1 commit into
mainfrom
more-trading-infos
Dec 2, 2025
Merged

feat: more trading infos by parsing more from trading summary endpoint#57
azerpas merged 1 commit into
mainfrom
more-trading-infos

Conversation

@azerpas
Copy link
Copy Markdown
Owner

@azerpas azerpas commented Dec 1, 2025

Add account optional field in TradingSummaryItem which contains useful infos like cash, activationDate, pricingName, etc...

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.55%. Comparing base (093a22a) to head (d6ed115).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   33.55%   33.55%           
=======================================
  Files           9        9           
  Lines         304      304           
=======================================
  Hits          102      102           
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@azerpas azerpas requested a review from Copilot December 1, 2025 17:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends trading summary parsing to include account-level details, exposing additional fields such as cash, activationDate, and pricingName via an optional account field on TradingSummaryItem.

  • Add optional account: Option to TradingSummaryItem
  • Update README macOS run instructions for quarantine removal and MFA note
  • Bump package version to 0.4.0

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/bourso_api/src/client/trade/mod.rs Adds account details to TradingSummaryItem alongside positions parsing.
README.md Revises macOS app approval steps and clarifies MFA requirements.
Cargo.toml Updates package version to 0.4.0 to reflect new features.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/bourso_api/src/client/trade/mod.rs
Comment thread README.md
@azerpas azerpas requested a review from Mathious6 December 1, 2025 17:58
Copy link
Copy Markdown
Collaborator

@Mathious6 Mathious6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 💪

Comment thread README.md
Comment thread src/bourso_api/src/client/trade/mod.rs
@azerpas azerpas marked this pull request as ready for review December 2, 2025 07:21
@azerpas azerpas merged commit 410d257 into main Dec 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants