Add linting Git workflow and local linting env#11
Merged
Conversation
GavinHeff
force-pushed
the
addLinting
branch
2 times, most recently
from
a959349 to
acae190
Compare
|
@GavinHeff have you tested this out manually on an Azimuth env? It looks like we are missing a CI job for this to test it out. |
m-bull
requested changes
May 21, 2025
m-bull
previously requested changes
Jun 17, 2025
Co-authored-by: Matt Anson <matta@stackhpc.com>
Co-authored-by: Matt Anson <matta@stackhpc.com>
Co-authored-by: Matt Anson <matta@stackhpc.com>
Co-authored-by: Matt Anson <matta@stackhpc.com>
openstack_compute_floatingip_associate_v2 is deprecated, updated to openstack_network_floatingip_associate_v2 and changed instance_id to port_id. In roles/cluster_infra/ templates/resources.tf.j2
GavinHeff
force-pushed
the
addLinting
branch
4 times, most recently
from
b677a23 to
cf24801
Compare
Fixed yaml lint issues after running superlint
Using ansible.builtin.service in place of service and adding handlers for roles/load_balancer/tasks/main.yml
Contributor
|
Deployment tested by hand and working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added super-lint.env so linting can be performed locally, along with
ansible-lint, yamllint and Git workflow for linting.