Skip to content

Commit 6c1fbba

Browse files
committed
chore(SpecificGroups/Alternating/Simple): remove a convert
1 parent 260979c commit 6c1fbba

2 files changed

Lines changed: 5 additions & 10 deletions

File tree

Mathlib/GroupTheory/Perm/Cycle/Type.lean

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,8 @@ theorem cycleType_extendDomain {β : Type*} [Fintype β] [DecidableEq β] {p :
308308
| induction_disjoint σ τ hd _ hσ hτ =>
309309
rw [hd.cycleType_mul, ← extendDomain_mul, (hd.extendDomain f).cycleType_mul, hσ, hτ]
310310

311-
theorem cycleType_ofSubtype {p : α → Prop} [DecidablePred p] {g : Perm (Subtype p)} :
311+
theorem cycleType_ofSubtype {p : α → Prop} [DecidablePred p] [Fintype (Subtype p)]
312+
{g : Perm (Subtype p)} :
312313
cycleType (ofSubtype g) = cycleType g :=
313314
cycleType_extendDomain (Equiv.refl (Subtype p))
314315

Mathlib/GroupTheory/SpecificGroups/Alternating/Simple.lean

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,8 @@ for `n = 3` or `n = 4`, this gives an Iwasawa structure of `alternatingGroup α`
5252
5353
## TODO
5454
55-
This file contains two uncomfortable uses of `convert`:
56-
57-
* on line 81, to identify `MulAut.conj` and `ConjAct.toConjAct`.
58-
59-
* on line 148, to match the subtype coercions for `Finset` and `Set`.
55+
This file contains one uncomfortable use of `convert`: on line 81, to identify `MulAut.conj`
56+
and `ConjAct.toConjAct`.
6057
6158
-/
6259

@@ -142,10 +139,7 @@ theorem mem_map_kleinFour_ofSubtype {s : Finset α} (hs : s.card = 4) (k : alter
142139
· obtain ⟨σ, rfl⟩ := (mem_range_ofSubtype_iff s k).mpr hk
143140
simp_rw [and_iff_right hk, Subgroup.mem_map, ofSubtype_inj, existsAndEq, and_true,
144141
← SetLike.mem_coe, coe_kleinFour_of_card_eq_four hs]
145-
simp only [Set.singleton_union, Set.mem_insert_iff, Set.mem_setOf_eq, OneMemClass.coe_eq_one,
146-
cycleType_ofSubtype, coe_ofSubtype, map_eq_one_iff _ Perm.ofSubtype_injective]
147-
apply or_congr_right
148-
convert Iff.rfl
142+
simp [cycleType_ofSubtype, coe_ofSubtype, map_eq_one_iff _ Perm.ofSubtype_injective]
149143
· simp_rw [hk, false_and, iff_false]
150144
contrapose! hk
151145
exact (mem_range_ofSubtype_iff s k).mp (Subgroup.map_le_range _ _ hk)

0 commit comments

Comments
 (0)