Keep ADS symbol handles alive for the layout lifetime#11
Open
ewastewa wants to merge 1 commit into
Open
Conversation
GetHandle returns a std::unique_ptr with a ResourceDeleter that issues SYM_RELEASEHND on destruction. Dereferencing the temporary and copying only the uint32_t left every layout pointing at a released handle. TwinCAT happens to keep handle slots live for top-level GVL and MAIN symbols held by other clients, but releases struct- and array-member handles immediately, so sum-reads against those returned garbage and crashed the read worker. Store the AdsHandle in std::optional alongside the cached uint32_t so the release only fires when the layout is destroyed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10.