Lordpooria#42
Open
pooria-zadeh wants to merge 2 commits into
Open
Conversation
Owner
|
hey! very cool. sorry I haven't been on in a while but it's always been on my radar to give this project some more love. I'll look at it in the coming days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First thanks for your beautiful package.
What I need is to handle some panels with controls out side the package, therefore I think if we create a provider to our project and manage our states (with performance considerations) we could extends some of functionality for other use cases.
So what I did was to added easy-peasy for state management and, just for a simple show case, moved one of states to store so that I could handle it from outside package.
I provided simple story as Customization refer to extending customization ability of this package
It's my first contribution, I tried to check all your guides but if there is any issue please let me know.