Make collapsed panel have flexGrow: 0; call onSaveSizes when collapsing a pane; add units to flex style for resizers#80
Open
godsamit wants to merge 2 commits into
Open
Make collapsed panel have flexGrow: 0; call onSaveSizes when collapsing a pane; add units to flex style for resizers#80godsamit wants to merge 2 commits into
flex style for resizers#80godsamit wants to merge 2 commits into
Conversation
flex style for resizers
|
any update on this PR, would be really appreciated to have this released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<SplitPane />. As suggested in the issue, there might be something wrong with the width calculation, since an inspection shows theflex-basisof children don't add up to the total container size... But for my use case, addingflexGrow: 0to collapsed panes solved my problem.onSaveSizesis not called when the user collapse a pane.