Skip to content

Make collapsed panel have flexGrow: 0; call onSaveSizes when collapsing a pane; add units to flex style for resizers#80

Open
godsamit wants to merge 2 commits into
b-zurg:masterfrom
godsamit:PR
Open

Make collapsed panel have flexGrow: 0; call onSaveSizes when collapsing a pane; add units to flex style for resizers#80
godsamit wants to merge 2 commits into
b-zurg:masterfrom
godsamit:PR

Conversation

@godsamit

@godsamit godsamit commented Jul 3, 2021

Copy link
Copy Markdown
  1. I noticed that collapsed panes will change sizes on container resize... Which happens quite often if you use multiple nested <SplitPane />. As suggested in the issue, there might be something wrong with the width calculation, since an inspection shows the flex-basis of children don't add up to the total container size... But for my use case, adding flexGrow: 0 to collapsed panes solved my problem.
  2. onSaveSizes is not called when the user collapse a pane.
  3. Added units to the flex property. As discovered here: collapsedSize and buttonPositionOffset adjustments #60

@godsamit godsamit changed the title Pr Make collapsed panel have flexGrow: 0; call onSaveSizes when collapsing a pane; add units to flex style for resizers Jul 3, 2021
@ysjn

ysjn commented Aug 21, 2021

Copy link
Copy Markdown

@b-zurg Hi, do you have time to look into this?
I use react-collapse-pane for my project and having same problem described in #60 #81.

This PR seems to fix them perfectly.
It would be appreciated to merge this fix.

@spencer741

spencer741 commented Sep 23, 2021

Copy link
Copy Markdown

bump. Would love the merge when you get the chance! @godsamit @b-zurg

@middiu

middiu commented Apr 28, 2022

Copy link
Copy Markdown

any update on this PR, would be really appreciated to have this released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants