fix first connection handler: clear widgets after SSH auth is completed

Author: b3b

pythonhere/main.py

@@ -103,7 +103,7 @@ def on_stop(self):
         Logger.info("PythonHere: app stopped")
 
     def on_ssh_connection_made(self):
-        """New SSH client connected handler."""
+        """New authenticated SSH client connected handler."""
         Logger.info("PythonHere: new SSH client connected")
         if not self.ssh_server_connected.is_set():
             self.ssh_server_connected.set()

pythonhere/server_here.py

@@ -12,9 +12,9 @@
 class PythonHereServer(SSHServerHere):
     """SSH server protocol handler."""
 
-    def connection_made(self, *args, **kwargs):
-        """Called when a channel is opened successfully."""
-        super().connection_made(*args, **kwargs)
+    def auth_completed(self):
+        """Authentication was completed successfully."""
+        super().auth_completed()
         App.get_running_app().on_ssh_connection_made()
 
 

tests/conftest.py

@@ -3,6 +3,7 @@
 import sys
 from pathlib import Path
 
+from asyncssh import PermissionDenied
 import nest_asyncio
 import pytest
 from kivy.config import Config
@@ -56,6 +57,16 @@ async def there(app_instance, connection_config):
     yield client
 
 
+@pytest.fixture
+async def there_with_wrong_password(app_instance, connection_config):
+    client = Client()
+    connection_config.password = "nowhere"
+    await asyncio.wait_for(app_instance.ssh_server_started.wait(), 5)
+    with pytest.raises(PermissionDenied):
+        await client.connect(connection_config)
+    yield client
+
+
 @pytest.fixture
 def nested_event_loop(event_loop):
     nest_asyncio.apply()

tests/test_main.py

@@ -1,5 +1,6 @@
 from pathlib import Path
 
+from asyncssh import PermissionDenied
 import pytest
 
 from main import PythonHereApp
@@ -24,6 +25,15 @@ async def test_code_line_executed(capfd, app_instance, there):
     assert capfd.readouterr().out == "hello there\n"
 
 
+@pytest.mark.asyncio
+async def test_connect_with_wrong_password(capfd, app_instance,
+                                           there_with_wrong_password):
+    with pytest.raises(PermissionDenied):
+        await there_with_wrong_password.runcode("print('hello there')")
+    app_instance.on_ssh_connection_made.assert_not_called()
+    assert not capfd.readouterr().out
+
+
 @pytest.mark.asyncio
 async def test_button_created(capfd, app_instance, there):
     await there.runcode(