Skip to content

Commit 3952594

Browse files
committed
object key deletion fix
1 parent 79949c1 commit 3952594

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"devDependencies": {
6060
"@babel/core": "^7.5.0",
6161
"@babel/preset-env": "^7.5.0",
62-
"@jupyterlab/builder": "^3.0.0",
62+
"@jupyterlab/builder": "^4.0.4",
6363
"@phosphor/application": "^1.6.0",
6464
"@phosphor/widgets": "^1.6.0",
6565
"@types/bootstrap": "^5.1.11",

src/widget.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -759,8 +759,8 @@ export class ActiveHTMLView extends DOMWidgetView {
759759
if (debug) {
760760
console.log(this.el, "Removing Event:", prop);
761761
}
762-
this.el.removeEventListener(prop, this._currentEvents[prop][1]);
763-
this._currentEvents.delete(prop);
762+
this.el.removeEventListener(prop, current[prop][1]);
763+
delete current[prop];
764764
}
765765
}
766766
}
@@ -815,7 +815,7 @@ export class ActiveHTMLView extends DOMWidgetView {
815815
console.log(this.el, "Removing On Handler:", prop);
816816
}
817817
this.model.off(prop, current[prop][1], this);
818-
current.delete(prop);
818+
delete current[prop];
819819
}
820820
}
821821
}

0 commit comments

Comments
 (0)