Skip to content

sdks/typescript: replace datetime / untyped duration types with Temporal#23

Closed
bcho with Copilot wants to merge 5 commits into
mainfrom
copilot/replace-datetime-with-temporal
Closed

sdks/typescript: replace datetime / untyped duration types with Temporal#23
bcho with Copilot wants to merge 5 commits into
mainfrom
copilot/replace-datetime-with-temporal

Conversation

Copilot AI commented Jan 14, 2026

Copy link
Copy Markdown
Contributor
  • Rebase on latest main branch with refactored TypeScript SDK structure
  • Adapt Temporal types to work with new sqlite-connection.ts module (replaces sqlite.ts)
  • Update sqlite-types.ts to support Temporal.Instant in SQLiteBindValue
  • Update sqlite-connection.ts to encode/decode Temporal types
  • Export Temporal types and helpers from main index
  • Update test setup to support both Date and Instant inputs
  • Update test assertions to use epochMilliseconds property
  • All 98 tests pass

Changes from main branch:

  • sqlite.tssqlite-connection.ts (new file structure)
  • absurd-types.ts → removed (moved to absurd.ts)
  • New absurd.ts with full implementation

Temporal API additions:

  • temporal-types.ts module with Instant, Duration types and conversion helpers
  • datetime columns now return Temporal.Instant instead of Date
  • Helper functions: instantFromDate, instantToDate, durationFromSeconds, etc.
Original prompt

This section details on the original issue you should resolve

<issue_title>sdks/typescript: replace datetime / untyped duration types with Temporal</issue_title>
<issue_description>Refs:

<agent_instructions>Please start with identifying usages first, then go minimal design & implementation; provide tests for the changes.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits January 14, 2026 07:25
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
…tring()

Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace datetime and untyped duration types with Temporal sdks/typescript: replace datetime / untyped duration types with Temporal Jan 14, 2026
Copilot AI requested a review from bcho January 14, 2026 07:40

@bcho bcho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot rebase the latest main branch and rework the change

Co-authored-by: bcho <1975118+bcho@users.noreply.github.com>

Copilot AI commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

@copilot rebase the latest main branch and rework the change

Rebased on main and reworked the changes to work with the refactored TypeScript SDK structure. The new sqlite-connection.ts now decodes datetime columns to Temporal.Instant and the exports have been updated. All 98 tests pass. (d0c3692)

Copilot AI requested a review from bcho January 19, 2026 01:45
@bcho bcho closed this Jan 19, 2026
@bcho bcho deleted the copilot/replace-datetime-with-temporal branch April 4, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sdks/typescript: replace datetime / untyped duration types with Temporal

2 participants