feat: implement queue clean up support

[bcho]

This pull request introduces a queue cleanup feature for the standalone app, enabling users to efficiently remove old terminal tasks or events from a queue. It adds a backend API and command to support this functionality, optimizes the cleanup implementation for better performance, and includes new benchmarks and tests to ensure correctness and scalability.

Backend/API and Integration:

• Adds a new cleanup_queue Tauri command and API endpoint, including the CleanupQueueOptions and CleanupResult types, allowing the frontend to trigger cleanup operations for tasks or events in a queue, with age-based filtering and batching. [1] [2] [3] [4] [5] [6] [7]
• Documents the UI and backend design for the queue cleanup feature in a new spec (queue-cleanup-ui.md).

Performance and Implementation Improvements:

• Refactors the cleanup logic in absurd_cleanup_tasks and absurd_cleanup_events to perform batched deletions using a single SQL statement per batch, significantly improving performance for large queues. [1] [2] [3]

Testing and Benchmarking:

• Adds a comprehensive benchmark (benches/cleanup.rs) using Criterion to measure cleanup performance across different batch sizes and data volumes. [1] [2]
• Adds a large-batch cleanup test to ensure correctness and scalability of the new batched deletion logic.

Build and Dependency Updates:

• Updates Cargo configuration to include the rlib crate type and adds dependencies for benchmarking. [1] [2]

Minor Improvements:

• Adds missing imports for params! macro in tests.

[Copilot]

Pull request overview

This PR introduces a comprehensive queue cleanup feature for the standalone app, enabling users to efficiently remove old terminal tasks or events from queues through a new UI modal dialog and supporting backend infrastructure.

Key Changes:

• Adds a new "Clean Up" button and modal dialog to the queues page with options to clean tasks and/or events by age
• Implements backend cleanup operations with batched SQL deletions for improved performance on large datasets
• Adds comprehensive benchmarks and tests to validate cleanup performance and correctness

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
standalone/src/routes/queues/+page.svelte	Adds cleanup modal UI with target selection (tasks/events), age filters (7d/30d/all), and validation
standalone/src/lib/providers/absurdData.ts	Defines cleanup types and integrates cleanupQueue method across all providers (Tauri, tRPC, mock)
standalone/src-tauri/src/worker.rs	Implements exponential backoff for worker restarts with crash tracking and improved error messaging
standalone/src-tauri/src/lib.rs	Registers new cleanup_queue Tauri command
standalone/src-tauri/src/dev_api.rs	Adds cleanupQueue tRPC procedure with input type mapping
standalone/src-tauri/src/db_commands.rs	Implements cleanup_queue command with batched deletion loop and SQL function wrappers
docs/specs/queue-cleanup-ui.md	Documents UI design, backend API, and implementation approach for the cleanup feature
absurd-sqlite-extension/src/run.rs	Refactors cleanup functions to use single batched DELETE statements with rowid IN subqueries
absurd-sqlite-extension/src/lib.rs	Adds large-batch cleanup test (12,000 tasks and events) and imports params! macro
absurd-sqlite-extension/benches/cleanup.rs	Adds Criterion benchmarks for cleanup operations across various batch sizes
absurd-sqlite-extension/Cargo.toml	Adds rlib crate type and Criterion benchmark configuration
Cargo.lock	Adds Criterion and its dependencies for benchmarking support

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The HTML entity ">" is displayed literally as text, showing "> 7d" to the user. Instead of using the HTML entity in the button text, use the actual greater-than character ">" or write it as text like "Older than 7d" for better clarity.

[Copilot]

The HTML entity ">" is displayed literally as text, showing "> 30d" to the user. Instead of using the HTML entity in the button text, use the actual greater-than character ">" or write it as text like "Older than 30d" for better clarity.

[Copilot]

The HTML entity ">" is displayed literally as text for all event age buttons. Instead of using the HTML entity in the button text, use the actual greater-than character ">" or write it as text like "Older than 7d/30d" for better clarity.

[Copilot]

The onclick handler uses a conditional expression that could fail to execute when the checkbox is checked quickly. The expression "cleanupTargets.tasks && (cleanupTaskAge = "7d")" will not execute the assignment if cleanupTargets.tasks is false, but this button is already disabled when tasks is false, making the conditional check redundant. Consider simplifying to just "cleanupTaskAge = '7d'" since the disabled attribute already prevents clicks when the checkbox is unchecked.

[Copilot]

The onclick handler uses a conditional expression that could fail to execute when the checkbox is checked quickly. The expression "cleanupTargets.tasks && (cleanupTaskAge = "30d")" will not execute the assignment if cleanupTargets.tasks is false, but this button is already disabled when tasks is false, making the conditional check redundant. Consider simplifying to just "cleanupTaskAge = '30d'" since the disabled attribute already prevents clicks when the checkbox is unchecked.

[Copilot]

The onclick handler uses a conditional expression that could fail to execute when the checkbox is checked quickly. The expression "cleanupTargets.tasks && (cleanupTaskAge = "all")" will not execute the assignment if cleanupTargets.tasks is false, but this button is already disabled when tasks is false, making the conditional check redundant. Consider simplifying to just "cleanupTaskAge = 'all'" since the disabled attribute already prevents clicks when the checkbox is unchecked.

[Copilot]

The modal implementation is missing keyboard escape handling. Users should be able to press the Escape key to close the modal, which is a standard accessibility requirement for modal dialogs. Add an onkeydown handler to close the modal when Escape is pressed and isCleaning is false.

[Copilot]

The documentation states "Target selector: Tasks | Events (default: Tasks)" but the actual implementation allows both targets to be selected simultaneously with independent checkboxes. The documentation should clarify that users can select one or both targets, not just a single exclusive selection.

Suggested change

	- Target selector: `Tasks` | `Events` (default: `Tasks`).
	- Target selector: independent checkboxes for `Tasks` and `Events` (both can be selected; default: `Tasks` checked, `Events` unchecked).

[Copilot]

The benchmark sizes include 10,000 items but the cleanup limit is set to 1,000. This could lead to a very small number of iterations (10) which may not provide statistically significant benchmark results. Consider adding larger benchmark sizes like 50,000 or 100,000 to better test the batching behavior under more realistic high-volume scenarios.

[Copilot]

The error message "Failed to clean up queue." is generic and doesn't provide users with actionable information about what went wrong. The actual error is only logged to the console. Consider including more specific error information in the displayed message, such as "Failed to clean up queue: [error details]" or at least different messages for different failure scenarios (e.g., network issues vs. invalid queue name).

Suggested change

	cleanupError = "Failed to clean up queue.";
	const errorMessage =
	error instanceof Error
	? error.message
	: typeof error === "string"
	? error
	: "Unknown error";
	cleanupError = `Failed to clean up queue: ${errorMessage}`;