fix(tab5): add missing app requires#129
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| REQUIRES backup_server connection_tester diag net_sntp ota_update settings_core | ||
| settings_ui m5stack_tab5 esp_wifi esp_netif esp_event nvs_flash | ||
| esp_http_server | ||
| esp_http_server chmorgan__esp-audio-player mooncake mooncake_log |
There was a problem hiding this comment.
[P1] Reference esp_audio_player with its sanitized component name
The new dependency list uses chmorgan__esp-audio-player, but ESP-IDF sanitizes component targets by replacing - with _ (e.g., the downloaded component lives under chmorgan__esp_audio_player). Because the target name in REQUIRES must match this sanitized form, CMake fails during configuration with “Unknown component chmorgan__esp-audio-player” and the Tab5 build cannot start. Replace the hyphen with an underscore so the dependency actually resolves.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
- Replaced the esp-audio-player dependency name with ESP-IDF’s sanitized
esp_audio_playeridentifier so the Tab5 main app resolves the component correctly. platforms/tab5/main/CMakeLists.txtL21-L27
Testing
⚠️ Not run (ESP-IDF toolchain unavailable in the provided environment)
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68cde09905ec8324964371e7d81b5641