Skip to content

fix(tab5): add missing app requires #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baba-dev merged 1 commit into from
Sep 20, 2025
Merged

fix(tab5): add missing app requires #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion platforms/tab5/main/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ idf_component_register(
INCLUDE_DIRS "." ${APP_LAYER_INCS}
REQUIRES backup_server connection_tester diag net_sntp ota_update settings_core
settings_ui m5stack_tab5 esp_wifi esp_netif esp_event nvs_flash
esp_http_server
esp_http_server chmorgan__esp-audio-player mooncake mooncake_log
Comment on lines 24 to +26
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Reference esp_audio_player with its sanitized component name

The new dependency list uses chmorgan__esp-audio-player, but ESP-IDF sanitizes component targets by replacing - with _ (e.g., the downloaded component lives under chmorgan__esp_audio_player). Because the target name in REQUIRES must match this sanitized form, CMake fails during configuration with “Unknown component chmorgan__esp-audio-player” and the Tab5 build cannot start. Replace the hyphen with an underscore so the dependency actually resolves.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

@baba-dev baba-dev Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex fix comments

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Testing

  • ⚠️ Not run (ESP-IDF toolchain unavailable in the provided environment)

View task →

smooth_ui_toolkit power_monitor_ina226 esp_video imlib
EMBED_TXTFILES "../audio/canon_in_d.mp3" "../audio/startup_sfx.mp3" "../audio/shutdown_sfx.mp3")

set(CUSTOM_ASSETS_DIR "${CMAKE_CURRENT_LIST_DIR}/../../../custom/assets")
Expand Down
Loading