Skip to content

Add cJSON dependency to Tab5 platform #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baba-dev merged 1 commit into from
Sep 20, 2025
Merged

Add cJSON dependency to Tab5 platform #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion platforms/tab5/main/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ idf_component_register(
REQUIRES backup_server connection_tester diag net_sntp ota_update settings_core
settings_ui m5stack_tab5 esp_wifi esp_netif esp_event nvs_flash
esp_http_server chmorgan__esp-audio-player mooncake mooncake_log
smooth_ui_toolkit power_monitor_ina226 esp_video imlib
smooth_ui_toolkit power_monitor_ina226 esp_video imlib cjson
EMBED_TXTFILES "../audio/canon_in_d.mp3" "../audio/startup_sfx.mp3" "../audio/shutdown_sfx.mp3")

set(CUSTOM_ASSETS_DIR "${CMAKE_CURRENT_LIST_DIR}/../../../custom/assets")
Expand Down
1 change: 1 addition & 0 deletions platforms/tab5/main/idf_component.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ dependencies:
chmorgan/esp-file-iterator: 1.0.0
espressif/led_strip: 3.0.0
espressif/esp_lcd_ili9881c: ^1.0.1
cjson: '*'
Comment on lines 10 to +11
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Resolve cJSON dependency with proper namespace

The manifest lists the new dependency as cjson: '*', but the component manager expects registry components to be fully qualified (e.g. espressif/cjson). With the current key there is no local component named cjson, so idf.py build will fail when the manager attempts to resolve this dependency. Keep the CMake REQUIRES cjson entry, but change the manifest to reference espressif/cjson (or drop the entry entirely if relying on the built‑in IDF component).

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

@baba-dev baba-dev Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex fix comments

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

  • Updated the Tab5 platform manifest to reference the cJSON dependency via the fully qualified espressif/cjson namespace so the component manager can resolve it correctly. platforms/tab5/main/idf_component.ymlL1-L25

Testing

  • ⚠️ idf.py lint (fails: command not found: idf.py in container environment)

View task →

settings_core:
path: ../../../components/settings_core
settings_ui:
Expand Down
Loading