Skip to content

chore: fix cjson dependency case#149

Merged
baba-dev merged 2 commits into
mainfrom
codex/fix-dependency-casing-in-idf_component.yml
Sep 20, 2025
Merged

chore: fix cjson dependency case#149
baba-dev merged 2 commits into
mainfrom
codex/fix-dependency-casing-in-idf_component.yml

Conversation

@baba-dev

Copy link
Copy Markdown
Owner

Summary

  • fix the cJSON manifest entry for the Tab5 main component so the dependency name matches the registry casing

Testing

  • ./tools/install_idf.sh
  • idf.py set-target esp32p4 (fails: missing credentials for espressif/cJSON package)
  • idf.py build (fails: missing credentials for espressif/cJSON package)

https://chatgpt.com/codex/tasks/task_e_68ce733bf5088324a92ad370919d01de

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines 10 to +11
espressif/esp_lcd_ili9881c: ^1.0.1
espressif/cjson: '*'
espressif/cJSON: '*'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Restore lowercase cjson component name

The ESP-IDF component registry treats names as case-sensitive and publishes the cJSON library under espressif/cjson. Switching the manifest to espressif/cJSON points the build system at a different package that does not exist publicly and results in the “missing credentials for espressif/cJSON” failure noted in the test output. To keep Tab5 builds reproducible, keep the dependency name lowercase or confirm the uppercase variant actually exists and is accessible.

Useful? React with 👍 / 👎.

@baba-dev baba-dev merged commit a1cdac4 into main Sep 20, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant