Skip to content

build: configure 16mb factory layout#159

Merged
baba-dev merged 1 commit into
mainfrom
codex/add-custom-partition-table-for-16mb-flash
Sep 20, 2025
Merged

build: configure 16mb factory layout#159
baba-dev merged 1 commit into
mainfrom
codex/add-custom-partition-table-for-16mb-flash

Conversation

@baba-dev
Copy link
Copy Markdown
Owner

Summary

  • add a dedicated 16 MB factory-only partition table for Tab5
  • wire sdkconfig defaults to always select the new table and disable SPIFFS staging
  • ensure CI reports flash usage after the build and drop the non-contiguous linker flag for the oversized app

Testing

  • ⚠️ idf.py build (aborted due to long compile time in the container)

https://chatgpt.com/codex/tasks/task_e_68cef25b6ac88324b743ebcd4a4060ed

@baba-dev baba-dev merged commit f9f5064 into main Sep 20, 2025
1 of 5 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines 2 to +6
CONFIG_ESPTOOLPY_FLASHMODE_QIO=y
CONFIG_ESPTOOLPY_FLASHSIZE_16MB=y
CONFIG_PARTITION_TABLE_CUSTOM=y
CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions_no_ota_16mb.csv"
CONFIG_PARTITION_TABLE_FILENAME="partitions_no_ota_16mb.csv"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Update sdkconfig to use new 16MB partition table

The defaults now reference partitions_no_ota_16mb.csv, but the committed sdkconfig still points to partitions.csv (10MB factory plus SPIFFS). Because idf.py uses the checked-in sdkconfig, CI and local builds will keep the old partition layout while the build scripts no longer stage SPIFFS assets. If the factory image grows past 10 MB, the build will still fail with a partition overflow despite the new table existing. Regenerate platforms/tab5/sdkconfig or adjust it to use the 16 MB CSV so the larger layout is actually applied.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant