build: configure 16mb factory layout#159
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| CONFIG_ESPTOOLPY_FLASHMODE_QIO=y | ||
| CONFIG_ESPTOOLPY_FLASHSIZE_16MB=y | ||
| CONFIG_PARTITION_TABLE_CUSTOM=y | ||
| CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions_no_ota_16mb.csv" | ||
| CONFIG_PARTITION_TABLE_FILENAME="partitions_no_ota_16mb.csv" |
There was a problem hiding this comment.
[P1] Update sdkconfig to use new 16MB partition table
The defaults now reference partitions_no_ota_16mb.csv, but the committed sdkconfig still points to partitions.csv (10MB factory plus SPIFFS). Because idf.py uses the checked-in sdkconfig, CI and local builds will keep the old partition layout while the build scripts no longer stage SPIFFS assets. If the factory image grows past 10 MB, the build will still fail with a partition overflow despite the new table existing. Regenerate platforms/tab5/sdkconfig or adjust it to use the 16 MB CSV so the larger layout is actually applied.
Useful? React with 👍 / 👎.
Summary
Testing
idf.py build(aborted due to long compile time in the container)https://chatgpt.com/codex/tasks/task_e_68cef25b6ac88324b743ebcd4a4060ed