refactor: consolidate clang tooling#178
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| fmt: ## Format source | ||
| ./tools/run_clang_format.sh | ||
| ./tools/clang_tools.sh format | ||
|
|
||
| tidy: build ## Static analysis | ||
| ./tools/run_clang_tidy.sh | ||
| tidy: ## Static analysis | ||
| ./tools/clang_tools.sh tidy |
There was a problem hiding this comment.
[P1] Use tabs for fmt/tidy recipes
The newly updated fmt and tidy targets indent their command lines with eight spaces rather than a tab. Make requires a literal tab to begin each recipe line, so make fmt or make tidy now stops with “missing separator” before ./tools/clang_tools.sh executes. Swap the leading spaces for a tab as done in the surrounding targets.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68d05c9b68948324a63b31b7557833cd