Skip to content

refactor: consolidate clang tooling#178

Merged
baba-dev merged 1 commit into
mainfrom
codex/merge-and-clean-tools-and-scripts-folder
Sep 21, 2025
Merged

refactor: consolidate clang tooling#178
baba-dev merged 1 commit into
mainfrom
codex/merge-and-clean-tools-and-scripts-folder

Conversation

@baba-dev

Copy link
Copy Markdown
Owner

Summary

  • replace the standalone clang-format, clang-tidy, and lint_autofix helpers with tools/clang_tools.sh
  • update the Makefile along with README and docs/DEV_SETUP.md to document the new workflow
  • drop the redundant scripts/format.sh wrapper and other legacy tooling

Testing

  • npx --yes markdownlint-cli docs (fails: legacy lint violations in untouched files)
  • npx --yes markdownlint-cli docs/DEV_SETUP.md
  • ./tools/clang_tools.sh --help

https://chatgpt.com/codex/tasks/task_e_68d05c9b68948324a63b31b7557833cd

@baba-dev baba-dev merged commit d98e18f into main Sep 21, 2025
4 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment thread Makefile
Comment on lines 21 to +25
fmt: ## Format source
./tools/run_clang_format.sh
./tools/clang_tools.sh format

tidy: build ## Static analysis
./tools/run_clang_tidy.sh
tidy: ## Static analysis
./tools/clang_tools.sh tidy

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Use tabs for fmt/tidy recipes

The newly updated fmt and tidy targets indent their command lines with eight spaces rather than a tab. Make requires a literal tab to begin each recipe line, so make fmt or make tidy now stops with “missing separator” before ./tools/clang_tools.sh executes. Swap the leading spaces for a tab as done in the surrounding targets.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant