Skip to content

fix: guard Tab5 hosted Wi-Fi and enable heap tracing#186

Merged
baba-dev merged 1 commit into
mainfrom
codex/fix-double-free,-stabilize-boot-process
Sep 22, 2025
Merged

fix: guard Tab5 hosted Wi-Fi and enable heap tracing#186
baba-dev merged 1 commit into
mainfrom
codex/fix-double-free,-stabilize-boot-process

Conversation

@baba-dev

Copy link
Copy Markdown
Owner

Summary

  • add an app-level Kconfig to disable the ESP-Hosted SDIO stack and guard the Tab5 HAL accordingly
  • gate the hosted dependencies in the component manifest/lockfile and expand sdkconfig defaults with heap diagnostics
  • start ESP-IDF heap tracing during app_main to capture corruptors earlier

Testing

  • idf.py build (fails: idf.py not available in container)

https://chatgpt.com/codex/tasks/task_e_68d133b76a988324a7e6191b721214f2

@baba-dev baba-dev merged commit d0f4f7e into main Sep 22, 2025
2 of 6 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

#if CONFIG_HEAP_TRACING
ESP_ERROR_CHECK(heap_trace_init_standalone(s_heap_trace_records, kHeapTraceDepth));
ESP_ERROR_CHECK(heap_trace_start(HEAP_TRACE_ALL));

[P1] Guard heap tracing with standalone Kconfig

The new heap tracing boot logic calls heap_trace_init_standalone and heap_trace_start under #if CONFIG_HEAP_TRACING. These APIs are only built when CONFIG_HEAP_TRACING_STANDALONE is enabled; enabling heap tracing with a different backend (e.g., system view or tracing to host) sets CONFIG_HEAP_TRACING=y but leaves CONFIG_HEAP_TRACING_STANDALONE=n, which will make this file fail to compile because the standalone functions are not declared. Please gate the code with CONFIG_HEAP_TRACING && CONFIG_HEAP_TRACING_STANDALONE or switch to the generic tracing APIs so builds using other heap trace modes continue to compile.


Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant