fix: guard Tab5 hosted Wi-Fi and enable heap tracing#186
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
M5Tab5-UserDemo/platforms/tab5/main/app_main.cpp
Lines 41 to 43 in c1d3851
[P1] Guard heap tracing with standalone Kconfig
The new heap tracing boot logic calls heap_trace_init_standalone and heap_trace_start under #if CONFIG_HEAP_TRACING. These APIs are only built when CONFIG_HEAP_TRACING_STANDALONE is enabled; enabling heap tracing with a different backend (e.g., system view or tracing to host) sets CONFIG_HEAP_TRACING=y but leaves CONFIG_HEAP_TRACING_STANDALONE=n, which will make this file fail to compile because the standalone functions are not declared. Please gate the code with CONFIG_HEAP_TRACING && CONFIG_HEAP_TRACING_STANDALONE or switch to the generic tracing APIs so builds using other heap trace modes continue to compile.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
Summary
Testing
idf.pynot available in container)https://chatgpt.com/codex/tasks/task_e_68d133b76a988324a7e6191b721214f2