Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| version: "0.1.0" | ||
|
|
||
| dependencies: | ||
| ## Required IDF version | ||
| idf: "~5.4" | ||
| espressif/esp_hosted: | ||
| version: 1.4.0 | ||
| rules: | ||
| - if: "$CONFIG{CONFIG_APP_ENABLE_WIFI_HOSTED} == y" | ||
| espressif/esp_wifi_remote: | ||
| version: 0.8.5 | ||
| rules: | ||
| - if: "$CONFIG{CONFIG_APP_ENABLE_WIFI_HOSTED} == y" | ||
| chmorgan/esp-audio-player: 1.0.7 | ||
| chmorgan/esp-file-iterator: 1.0.0 | ||
| espressif/led_strip: 3.0.0 | ||
| espressif/esp_lcd_ili9881c: ^1.0.1 | ||
|
|
||
| espressif/esp_wifi_remote: "*" | ||
|
|
There was a problem hiding this comment.
[P1] Restore esp_hosted dependency for hosted Wi‑Fi builds
The manifest no longer declares espressif/esp_hosted, but the code base still includes esp_hosted_api.h and calls esp_hosted_init/esp_hosted_deinit when CONFIG_APP_ENABLE_WIFI_HOSTED is enabled (see custom/integration/wifi_remote/hosted_safe.c L14‑105 and hal/components/hal_wifi.cpp L22‑24). With the default now set to y, those headers and symbols must come from the esp_hosted component. esp_wifi_remote does not ship that API, so the build will fail with missing headers or unresolved symbols once a clean dependency resolve runs. The manifest needs to keep espressif/esp_hosted (guarded by the same Kconfig option) or the code must drop the calls.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68d15bda29048324a89ea130cf01ef15