Add dev tooling scaffolding and test harnesses#68
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| def slugify(path: Path) -> str: | ||
| # Use the relative path (without extension) as the base id | ||
| parts = path.as_posix() | ||
| parts = re.sub(r"[^0-9a-zA-Z/]+", "_", parts) | ||
| parts = parts.strip("_/") | ||
| parts = parts.replace("/", "_") | ||
| slug = parts.lower() | ||
| return slug or "asset" |
There was a problem hiding this comment.
[P1] Ensure asset IDs remain unique after slugifying paths
The asset generator derives asset_id by normalizing the relative path, replacing / with _ and stripping non‑alphanumeric characters. This makes different source files collapse to the same slug (e.g. icons/home.png vs icons-home.png both become icons_home). When such a collision occurs the later asset overwrites the .bin produced for the earlier one and both manifest entries point at the same binary, so one of the images will be wrong or missing at runtime. Consider preserving directory separators (e.g. hashing the full relative path or including a UUID) or detecting duplicates before writing files.
Useful? React with 👍 / 👎.
Summary
Testing
make testnpx markdownlint-cli DOCS./tools/check_secrets.shhttps://chatgpt.com/codex/tasks/task_e_68cc75b42a888324bf24b2ee26ea3af4