Skip to content

Add dev tooling scaffolding and test harnesses#68

Merged
baba-dev merged 2 commits into
mainfrom
codex/add-reproducible-dev-environment-setup
Sep 18, 2025
Merged

Add dev tooling scaffolding and test harnesses#68
baba-dev merged 2 commits into
mainfrom
codex/add-reproducible-dev-environment-setup

Conversation

@baba-dev
Copy link
Copy Markdown
Owner

Summary

  • replace the devcontainer with an ESP-IDF 5.5 image setup, git feature, and ccache mount
  • add repo Makefile, host/unit/UI snapshot tests, LVGL snapshot golden, and core utility modules
  • introduce CI workflows, contribution docs, asset pipeline scripts, and trace logging utilities

Testing

  • make test
  • npx markdownlint-cli DOCS
  • ./tools/check_secrets.sh

https://chatgpt.com/codex/tasks/task_e_68cc75b42a888324bf24b2ee26ea3af4

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment thread tools/gen_assets.py
Comment on lines +41 to +48
def slugify(path: Path) -> str:
# Use the relative path (without extension) as the base id
parts = path.as_posix()
parts = re.sub(r"[^0-9a-zA-Z/]+", "_", parts)
parts = parts.strip("_/")
parts = parts.replace("/", "_")
slug = parts.lower()
return slug or "asset"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Ensure asset IDs remain unique after slugifying paths

The asset generator derives asset_id by normalizing the relative path, replacing / with _ and stripping non‑alphanumeric characters. This makes different source files collapse to the same slug (e.g. icons/home.png vs icons-home.png both become icons_home). When such a collision occurs the later asset overwrites the .bin produced for the earlier one and both manifest entries point at the same binary, so one of the images will be wrong or missing at runtime. Consider preserving directory separators (e.g. hashing the full relative path or including a UUID) or detecting duplicates before writing files.

Useful? React with 👍 / 👎.

@baba-dev baba-dev merged commit 6931ee4 into main Sep 18, 2025
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant