Skip to content

fix: cache theme option count in settings page #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baba-dev merged 1 commit into from
Sep 19, 2025
Merged

fix: cache theme option count in settings page #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions custom/ui/pages/ui_page_settings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ static const theme_option_t k_theme_options[] = {
{"midnight", "Midnight"},
};

static const size_t kThemeOptionCount = sizeof(k_theme_options) / sizeof(k_theme_options[0]);

static const char* k_theme_options_list = "System Default\nSolar\nMidnight";

static const struct
Expand Down Expand Up @@ -550,7 +552,7 @@ static void theme_state_async_cb(void* param)

if (ctx->theme_dropdown != NULL && payload->variant_id[0] != '\0')
{
for (uint32_t i = 0; i < LV_ARRAY_SIZE(k_theme_options); i++)
for (uint32_t i = 0; i < kThemeOptionCount; i++)
{
if (strcmp(k_theme_options[i].id, payload->variant_id) == 0)
{
Expand Down Expand Up @@ -678,7 +680,7 @@ static void theme_dropdown_cb(lv_event_t* event)
if (ctx->actions_bound && ctx->actions.set_theme_variant != NULL)
{
uint16_t index = lv_dropdown_get_selected(lv_event_get_target(event));
if (index < LV_ARRAY_SIZE(k_theme_options))
if (index < kThemeOptionCount)
{
ctx->actions.set_theme_variant(k_theme_options[index].id, ctx->actions_user_data);
}
Expand Down
Loading