Skip to content

fix(build): normalize settings includes#87

Merged
baba-dev merged 1 commit into
mainfrom
codex/refactor-header-includes-in-app_launcher
Sep 19, 2025
Merged

fix(build): normalize settings includes#87
baba-dev merged 1 commit into
mainfrom
codex/refactor-header-includes-in-app_launcher

Conversation

@baba-dev
Copy link
Copy Markdown
Owner

Summary

  • stop including the settings controller header from the custom/ path in the launcher view header
  • include integration/settings_controller.h and ui/pages/ui_page_settings.h in the launcher view implementation
  • update settings_controller.cpp to include the integration header and the relocated settings page header

Testing

  • clang-format app/apps/app_launcher/view/view.cpp app/apps/app_launcher/view/view.h custom/integration/settings_controller.cpp
  • idf.py build (fails: command not found)

https://chatgpt.com/codex/tasks/task_e_68cd4335390c8324a99a742dbc3f4758

@baba-dev baba-dev merged commit c7baa10 into main Sep 19, 2025
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant