feat: integrate CCTV state model and controller#95
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| +else if (code == UI_PAGE_CCTV_EVENT_OPEN_CLIP) + | ||
| { | ||
| +const auto* clip = | ||
| static_cast<const ui_page_cctv_clip_event_t*>(lv_event_get_param(event)); | ||
| +if (clip != nullptr) + |
There was a problem hiding this comment.
[P0] Remove diff markers from clip event handler
The PageEventCb branch that should react to UI_PAGE_CCTV_EVENT_OPEN_CLIP still contains the literal + prefixes from the patch (+else if, +const auto* clip, etc.). These stray characters make the file fail to compile, so the launcher cannot build and the controller never receives clip-open events. Drop the + markers and keep a normal else if block.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
- Restored the CCTV clip-open event handling branch to a standard
else if, ensuring clip requests reach the controller without stray diff markers that broke compilation. custom/integration/cctv_controller.cppL120-L144
Testing
⚠️ idf.py build(not run; environment does not provide ESP-IDF tooling for this quick fix)
1 participant
Summary
Testing
idf.py build(fails: command not found)https://chatgpt.com/codex/tasks/task_e_68cd5a35c21483248afa2b692def3e59