Skip to content

fix: register core component for Tab5 build#99

Merged
baba-dev merged 1 commit into
mainfrom
codex/update-include-directive-in-settings_controller.cpp
Sep 19, 2025
Merged

fix: register core component for Tab5 build#99
baba-dev merged 1 commit into
mainfrom
codex/update-include-directive-in-settings_controller.cpp

Conversation

@baba-dev
Copy link
Copy Markdown
Owner

Summary

  • register the core component so its headers are exported to the include path
  • include app_trace via the component's public header rather than a nested path
  • add a minimal CMakeLists.txt for the core component sources

Testing

  • idf.py build (fails: command not found; ESP-IDF not available in container)

https://chatgpt.com/codex/tasks/task_e_68cd61c0ce708324a19e5bb6bf8754ec

@baba-dev baba-dev merged commit 24d3708 into main Sep 19, 2025
1 of 7 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines 21 to 25
#include <thread>
#include <vector>

#include "core/app_trace.h"
#include "app_trace.h"
#include "hal/hal.h"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Add dependency on new core component for app_trace include

Switching the include from "core/app_trace.h" to "app_trace.h" assumes that the core component now exports its include directory through idf_component_register. However, the main Tab5 target (and the desktop build) does not declare core in its idf_component_register(... REQUIRES ...), so this public include path is never added to the compilation of settings_controller.cpp. As a result, idf.py build will fail with app_trace.h: No such file or directory. Either revert to the prefixed include or add core to the main component’s REQUIRES so the header is visible.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant