fix: register core component for Tab5 build#99
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| #include <thread> | ||
| #include <vector> | ||
|
|
||
| #include "core/app_trace.h" | ||
| #include "app_trace.h" | ||
| #include "hal/hal.h" |
There was a problem hiding this comment.
[P1] Add dependency on new core component for app_trace include
Switching the include from "core/app_trace.h" to "app_trace.h" assumes that the core component now exports its include directory through idf_component_register. However, the main Tab5 target (and the desktop build) does not declare core in its idf_component_register(... REQUIRES ...), so this public include path is never added to the compilation of settings_controller.cpp. As a result, idf.py build will fail with app_trace.h: No such file or directory. Either revert to the prefixed include or add core to the main component’s REQUIRES so the header is visible.
Useful? React with 👍 / 👎.
Summary
Testing
idf.py build(fails: command not found; ESP-IDF not available in container)https://chatgpt.com/codex/tasks/task_e_68cd61c0ce708324a19e5bb6bf8754ec