Store original name in reloption for temp table and index on it

Author: anju15bharti

contrib/babelfishpg_tsql/runtime/functions.c

@@ -51,8 +51,14 @@
 #include "utils/float.h"
 #include "utils/xid8.h"
 #include "utils/xml.h"
+#include "catalog/pg_class_d.h"
 #include <math.h>
 
+extern const char *ATTOPTION_BBF_ORIGINAL_TABLE_NAME;
+extern char *get_value_by_name_from_array(ArrayType *array, const char *name);
+
+static char *get_orig_temp_table_name(Oid relid);
+
 #include "../src/babelfish_version.h"
 #include "../src/datatype_info.h"
 #include "../src/pltsql.h"
@@ -1319,7 +1325,19 @@ get_enr_list(PG_FUNCTION_ARGS)
 		MemSet(nulls, 0, sizeof(nulls));
 
 		values[0] = ((EphemeralNamedRelationMetadata) lfirst(lc))->reliddesc;
-		values[1] = CStringGetTextDatum(((EphemeralNamedRelationMetadata) lfirst(lc))->name);
+		{
+			EphemeralNamedRelationMetadata md = (EphemeralNamedRelationMetadata) lfirst(lc);
+			const char *name = md->name;
+
+			/* Use original untruncated name from reloptions if available */
+			if (md->enrtype == ENR_TSQL_TEMP)
+			{
+				char *orig = get_orig_temp_table_name(md->reliddesc);
+				if (orig)
+					name = orig;
+			}
+			values[1] = CStringGetTextDatum(name);
+		}
 
 		tuplestore_putvalues(tupstore, tupdesc, values, nulls);
 	}
@@ -2798,6 +2816,32 @@ object_id(PG_FUNCTION_ARGS)
  * 		if there is no such object in specified database, if database id is not provided it will lookup in current database
  * 		if user don't have right permission
  */
+/*
+ * get_orig_temp_table_name - Get original untruncated name from reloptions.
+ * Returns palloc'd string or NULL if not found.
+ */
+static char *
+get_orig_temp_table_name(Oid relid)
+{
+	HeapTuple	tuple = SearchSysCache1(RELOID, ObjectIdGetDatum(relid));
+	char	   *orig = NULL;
+
+	if (HeapTupleIsValid(tuple))
+	{
+		Datum	datum;
+		bool	isnull;
+
+		datum = SysCacheGetAttr(RELOID, tuple, Anum_pg_class_reloptions, &isnull);
+		if (!isnull)
+		{
+			ArrayType *reloptions = DatumGetArrayTypeP(datum);
+			orig = get_value_by_name_from_array(reloptions, ATTOPTION_BBF_ORIGINAL_TABLE_NAME);
+		}
+		ReleaseSysCache(tuple);
+	}
+	return orig;
+}
+
 Datum
 object_name(PG_FUNCTION_ARGS)
 {
@@ -2844,7 +2888,12 @@ object_name(PG_FUNCTION_ARGS)
 	enr = GetENRTempTableWithOid(object_id, false);
 	if (enr != NULL && enr->md.enrtype == ENR_TSQL_TEMP)
 	{
-		PG_RETURN_VARCHAR_P((VarChar *) cstring_to_text(enr->md.name));
+		const char *name = enr->md.name;
+		char *orig = get_orig_temp_table_name(object_id);
+
+		if (orig)
+			name = orig;
+		PG_RETURN_VARCHAR_P((VarChar *) cstring_to_text(name));
 	}
 
 	/* search in pg_class by object_id */
@@ -2855,7 +2904,17 @@ object_name(PG_FUNCTION_ARGS)
 		if (pg_class_aclcheck(object_id, user_id, ACL_SELECT) == ACLCHECK_OK)
 		{
 			Form_pg_class pg_class = (Form_pg_class) GETSTRUCT(tuple);
-			result_text = cstring_to_text(NameStr(pg_class->relname)); // make a copy before releasing syscache
+
+			if (pg_class->relpersistence == RELPERSISTENCE_TEMP &&
+				NameStr(pg_class->relname)[0] == '#')
+			{
+				char *orig = get_orig_temp_table_name(object_id);
+				if (orig)
+					result_text = cstring_to_text(orig);
+			}
+
+			if (!result_text)
+				result_text = cstring_to_text(NameStr(pg_class->relname));
 			schema_id = pg_class->relnamespace;
 		}
 		ReleaseSysCache(tuple);

contrib/babelfishpg_tsql/src/backend_parser/gram-tsql-rule.y

@@ -3557,6 +3557,11 @@ tsql_IndexStmt:
 					n->transformed = false;
 					n->if_not_exists = false;
 
+					if (n->idxname)
+						n->options = lappend(n->options,
+							makeDefElem("name_location",
+								(Node *) makeInteger(@7), @7));
+
 					tsql_index_nulls_order(n->indexParams, n->accessMethod);
 					$$ = (Node *)n;
 				}

contrib/babelfishpg_tsql/src/backend_parser/scan-tsql-rule.l

@@ -153,6 +153,8 @@
 <tsql>{tsql_ttname}	{
 					SET_YYLLOC();
 					yylval->str = pstrdup(yytext);
+					if (yyleng >= NAMEDATALEN)
+						truncate_identifier(yylval->str, yyleng, true);
 					return IDENT;
 				}
 

contrib/babelfishpg_tsql/src/hooks.c

@@ -2500,7 +2500,8 @@ pltsql_post_transform_table_definition(ParseState *pstate, RangeVar *relation, c
 	 * Only store original_name if there's a difference, and if the difference
 	 * is only in capitalization
 	 */
-	if (strncmp(relname, original_name, strlen(relname)) != 0 && strncasecmp(relname, original_name, strlen(relname)) == 0)
+	if ((strncmp(relname, original_name, strlen(relname)) != 0 && strncasecmp(relname, original_name, strlen(relname)) == 0) ||
+		(relation->relpersistence == RELPERSISTENCE_TEMP && original_name[0] == '#' && strlen(original_name) >= NAMEDATALEN))
 	{
 		/*
 		 * add "ALTER TABLE SET (bbf_original_table_name=<original_name>)" to

contrib/babelfishpg_tsql/src/pl_handler.c

@@ -5411,6 +5411,29 @@ bbf_ProcessUtility(PlannedStmt *pstmt,
 					}
 					if (original_name && !stmt->isconstraint)
 					{
+						/*
+						 * For indexes on temp tables, extract full original
+						 * name from query string using name_location stored
+						 * by the parser in options.
+						 */
+						if (stmt->relation->relpersistence == RELPERSISTENCE_TEMP &&
+							stmt->relation->relname[0] == '#')
+						{
+							ListCell *lc;
+							foreach(lc, stmt->options)
+							{
+								DefElem *opt = (DefElem *) lfirst(lc);
+								if (strcmp(opt->defname, "name_location") == 0)
+								{
+									int loc = intVal(opt->arg);
+									char *full_name = extract_identifier(queryString + loc, NULL);
+									if (full_name)
+										original_name = full_name;
+									stmt->options = foreach_delete_current(stmt->options, lc);
+									break;
+								}
+							}
+						}
 						/* Store the original index name in reloptions */
 						exec_add_original_index_name(stmt->idxname, stmt->relation->schemaname, original_name);
 						/* Restore the original index name so that cached plan remains valid */