Heap-allocate insert_exec_ctx with NULL guards, resolve unqualified target

schema via the user's default schema, remove the unnecessary LockRelationOid

try/catch, clean up the column-count probe error handling, and guard

table-variable cleanup against an aborted transaction (fixes an

IsTransactionState() crash on the INSERT EXEC error path in a function).

Adds same-session DDL detection tests.

Author: monk0707

contrib/babelfishpg_tds/src/backend/tds/tdsresponse.c

@@ -2708,13 +2708,8 @@ StatementEnd_Internal(PLtsql_execstate *estate, PLtsql_stmt *stmt, bool error)
 				ListCell   *l;
 				PLtsql_expr *expr = ((PLtsql_stmt_execsql *) stmt)->sqlstmt;
 
-				/*
-				 * True if this statement runs inside an INSERT EXEC. Covers
-				 * both paths: the new path uses the global context
-				 * (pltsql_insert_exec_active), the legacy path uses the
-				 * per-estate flag (estate->insert_exec).
-				 */
-				bool insert_exec_active = estate->insert_exec ||
+				/* True if running inside a new-path INSERT EXEC. */
+				bool insert_exec_active =
 					(pltsql_plugin_handler_ptr->pltsql_insert_exec_active &&
 					 pltsql_plugin_handler_ptr->pltsql_insert_exec_active());
 
@@ -2742,19 +2737,20 @@ StatementEnd_Internal(PLtsql_execstate *estate, PLtsql_stmt *stmt, bool error)
 								 * and it just returned error.
 								 */
 								row_count_valid =
+									!estate->insert_exec &&
 									!insert_exec_active &&
 									!(markErrorFlag &&
 									  ((PLtsql_stmt_execsql *) stmt)->insert_exec);
 							}
 							else if (plansource->commandTag == CMDTAG_UPDATE)
 							{
 								command_type = TDS_CMD_UPDATE;
-								row_count_valid = !insert_exec_active;
+								row_count_valid = !estate->insert_exec && !insert_exec_active;
 							}
 							else if (plansource->commandTag == CMDTAG_DELETE)
 							{
 								command_type = TDS_CMD_DELETE;
-								row_count_valid = !insert_exec_active;
+								row_count_valid = !estate->insert_exec && !insert_exec_active;
 							}
 
 							/*
@@ -2764,7 +2760,7 @@ StatementEnd_Internal(PLtsql_execstate *estate, PLtsql_stmt *stmt, bool error)
 							else if (plansource->commandTag == CMDTAG_SELECT)
 							{
 								command_type = TDS_CMD_SELECT;
-								row_count_valid = !insert_exec_active;
+								row_count_valid = !estate->insert_exec && !insert_exec_active;
 							}
 						}
 					}

contrib/babelfishpg_tsql/src/hooks.c

@@ -3658,8 +3658,10 @@ bbf_object_access_hook(ObjectAccessType access, Oid classId, Oid objectId, int s
 	 */
 	if ((access == OAT_POST_ALTER || access == OAT_DROP) && classId == RelationRelationId)
 	{
-		if (OidIsValid(insert_exec_ctx.target_rel_oid) && objectId == insert_exec_ctx.target_rel_oid)
-			insert_exec_ctx.is_target_relation_modified = true;
+		if (insert_exec_ctx != NULL &&
+			OidIsValid(insert_exec_ctx->target_rel_oid) &&
+			objectId == insert_exec_ctx->target_rel_oid)
+			insert_exec_ctx->is_target_relation_modified = true;
 	}
 }
 

contrib/babelfishpg_tsql/src/iterative_exec.c

@@ -1621,7 +1621,12 @@ exec_stmt_iterative(PLtsql_execstate *estate, ExecCodes *exec_codes, ExecConfig_
 
 					/* INSERT EXEC: re-throw errors that must abort the whole flush. */
 					if (ignore_catch_block_for_insert_exec(estate))
+					{
+						elog(DEBUG4,
+							 "INSERT EXEC failed due to error (sqlerrcode=%d) inside procedure TRY-CATCH; re-throwing to abort flush",
+							 estate->cur_error->error ? estate->cur_error->error->sqlerrcode : 0);
 						ReThrowError(estate->cur_error->error);
+					}
 
 					/* Goto error handling blocks */
 					*pc = err_handler_pc - 1;	/* same as how goto handles PC */