[BABEL] Insert exec pr5 code cleanup#4856
Open
monk0707 wants to merge 5 commits into
Open
Conversation
OOM, FATAL, and admin shutdown so they cannot be silently swallowed. - Allocate target_table in TopTransactionContext so the safety-net xact cleanup never dereferences a freed per-statement allocation.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, Babelfish carries two parallel implementations of
INSERT ... EXECUTE, gated by thebabelfishpg_tsql.enable_new_insert_execGUC.The original path goes via a tuple store based approach. The redesigned path introduced in PR0–PR4 (#4780–#4847) works on a temp table based approach.
The cleanup removes the
enable_new_insert_execGUC declaration, and the legacy insert-exec tuple store path.Related engine PR : babelfish-for-postgresql/postgresql_modified_for_babelfish#771
Issues Resolved
Final cleanup of the INSERT-EXEC redesign stack (PR0–PR4: #4780, #4781, #4782, #4783, #4847).
Test Scenarios Covered
EXEC sp_executesqlINSERT EXEC, dynamic-SQL INSERT EXEC, cross-database INSERT EXEC, INSERT EXEC into table variables, INSERT EXEC inside TRY/CATCH, and INSERT EXEC with explicit column lists.babelfishpg_tsql.enable_new_insert_execis removed frompg_settings. Any tooling or test harness that explicitly sets this GUC will receive an "unrecognized configuration parameter" error and must drop the setting.Check List
--signoffBy submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.