Skip to content

Fix server crash during concurrent DROP+CREATE+EXEC with track_functions=all #4859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RuchaSK1 wants to merge 2 commits into from
+17 −0
Closed

Fix server crash during concurrent DROP+CREATE+EXEC with track_functions=all #4859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6274da
Fix server crash during concurrent DROP+CREATE+EXEC with track_functi…
Jun 16, 2026
1a4acfc
Merge remote-tracking branch 'upstream/BABEL_6_X_DEV' into jira-babel…
Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions contrib/babelfishpg_tsql/src/hooks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,9 @@ extern bool called_for_tsql_itvf_func();
static void is_function_pg_stat_valid(FunctionCallInfo fcinfo,
PgStat_FunctionCallUsage *fcu,
char prokind, bool finalize);
static bool babelfish_pgstat_init_function_usage(FunctionCallInfo fcinfo,
PgStat_FunctionCallUsage *fcu,
char *procname);
static AclResult pltsql_ExecFuncProc_AclCheck(Oid funcid, Expr *expr);
static bool allow_storing_init_privs(Oid objoid, Oid classoid, int objsubid);
static bool pltsql_validateCachedPlanSearchPath(SPIPlanPtr plan);
Expand Down Expand Up @@ -389,6 +392,7 @@ static ExecFuncProc_AclCheck_hook_type prev_ExecFuncProc_AclCheck_hook = NULL;
static bbf_execute_grantstmt_as_dbsecadmin_hook_type prev_bbf_execute_grantstmt_as_dbsecadmin_hook = NULL;
static bbf_check_member_has_direct_priv_to_grant_role_hook_type prev_bbf_check_member_has_direct_priv_to_grant_role_hook = NULL;
static validateCachedPlanSearchPath_hook_type prev_validateCachedPlanSearchPath_hook = NULL;
static pgstat_function_wrapper_hook_type prev_pgstat_function_wrapper_hook = NULL;
static pre_QueryRewrite_hook_type prev_pre_QueryRewrite_hook = NULL;
ExecInitParallelPlan_hook_type prev_ExecInitParallelPlan_hook = NULL;
ParallelQueryMain_hook_type prev_ParallelQueryMain_hook = NULL;
Expand Down Expand Up @@ -616,6 +620,9 @@ InstallExtendedHooks(void)
prev_pltsql_pgstat_end_function_usage_hook = pltsql_pgstat_end_function_usage_hook;
pltsql_pgstat_end_function_usage_hook = is_function_pg_stat_valid;

prev_pgstat_function_wrapper_hook = pgstat_function_wrapper_hook;
pgstat_function_wrapper_hook = babelfish_pgstat_init_function_usage;

prev_pltsql_unique_constraint_nulls_ordering_hook = pltsql_unique_constraint_nulls_ordering_hook;
pltsql_unique_constraint_nulls_ordering_hook = unique_constraint_nulls_ordering;

Expand Down Expand Up @@ -739,6 +746,7 @@ UninstallExtendedHooks(void)
called_from_tsql_insert_exec_hook = pre_called_from_tsql_insert_exec_hook;
called_for_tsql_itvf_func_hook = prev_called_for_tsql_itvf_func_hook;
pltsql_pgstat_end_function_usage_hook = prev_pltsql_pgstat_end_function_usage_hook;
pgstat_function_wrapper_hook = prev_pgstat_function_wrapper_hook;
pltsql_unique_constraint_nulls_ordering_hook = prev_pltsql_unique_constraint_nulls_ordering_hook;
pltsql_strpos_non_determinstic_hook = prev_pltsql_strpos_non_determinstic_hook;
pltsql_replace_non_determinstic_hook = prev_pltsql_replace_non_determinstic_hook;
Expand Down Expand Up @@ -9305,3 +9313,12 @@ pltsql_post_transform_expr_recurse(ParseState *pstate, Node *expr)

return expr;
}

static bool
babelfish_pgstat_init_function_usage(FunctionCallInfo fcinfo,
PgStat_FunctionCallUsage *fcu,
char *procname)
{
pgstat_init_function_usage_no_drop(fcinfo, fcu);
return true;
}
Loading