Skip to content

Commit ebd698f

Browse files
ritanwarshardgupta
authored andcommitted
Fix PgReThrowError to even make copy of const strings
Task: BABEL-5157 Signed-off-by: Rishabh Tanwar <ritanwar@amazon.com>
1 parent 1e6271d commit ebd698f

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

src/backend/utils/error/elog.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1793,6 +1793,14 @@ ReThrowError(ErrorData *edata)
17931793
memcpy(newedata, edata, sizeof(ErrorData));
17941794

17951795
/* Make copies of separately-allocated fields */
1796+
if (newedata->filename)
1797+
newedata->filename = pstrdup(newedata->filename);
1798+
if (newedata->funcname)
1799+
newedata->funcname = pstrdup(newedata->funcname);
1800+
if (newedata->domain)
1801+
newedata->domain = pstrdup(newedata->domain);
1802+
if (newedata->context_domain)
1803+
newedata->context_domain = pstrdup(newedata->context_domain);
17961804
if (newedata->message)
17971805
newedata->message = pstrdup(newedata->message);
17981806
if (newedata->detail)
@@ -1805,6 +1813,8 @@ ReThrowError(ErrorData *edata)
18051813
newedata->context = pstrdup(newedata->context);
18061814
if (newedata->backtrace)
18071815
newedata->backtrace = pstrdup(newedata->backtrace);
1816+
if (newedata->message_id)
1817+
newedata->message_id = pstrdup(newedata->message_id);
18081818
if (newedata->schema_name)
18091819
newedata->schema_name = pstrdup(newedata->schema_name);
18101820
if (newedata->table_name)

0 commit comments

Comments
 (0)