Skip to content

Fix: ENR temp table creation fails for long table names #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anju15bharti wants to merge 3 commits into
base: BABEL_6_X_DEV__PG_18_X
Choose a base branch
from
+0 −0
Open

Fix: ENR temp table creation fails for long table names #769

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ebb3e6
Fix: ENR temp table creation fails for long table names
Jun 1, 2026
6368e37
Rename effective_relname variable
Jun 9, 2026
6c45a53
Revert: ENR temp table creation for long table names
Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion src/backend/commands/tablecmds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,13 +797,26 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,
LOCKMODE parentLockmode;
Oid accessMethodId = InvalidOid;
ObjectAddress tsql_tabletype_address;
const char *effective_relname;

/*
* Truncate relname to appropriate length (probably a waste of time, as
* parser should have done this already).
*/
strlcpy(relname, stmt->relation->relname, NAMEDATALEN);

/*
* For T-SQL #temp tables, ENR stores names in heap-allocated memory
* without NAMEDATALEN limit. Use the full original name so that
* subsequent lookups via the scanner match the registered ENR entry.
*/
if (sql_dialect == SQL_DIALECT_TSQL &&
stmt->relation->relpersistence == RELPERSISTENCE_TEMP &&
stmt->relation->relname[0] == '#')
Comment thread
anju15bharti marked this conversation as resolved.
Outdated
effective_relname = stmt->relation->relname;
else
effective_relname = relname;

/*
* Check consistency of arguments
*/
Expand Down Expand Up @@ -1078,7 +1091,7 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,
* passed in for immediate handling --- since they don't need parsing,
* they can be stored immediately.
*/
relationId = heap_create_with_catalog(relname,
relationId = heap_create_with_catalog(effective_relname,
namespaceId,
tablespaceId,
InvalidOid,
Expand Down Expand Up @@ -5821,6 +5834,23 @@ ATParseTransformCmd(List **wqueue, AlteredTableInfo *tab, Relation rel,
makeRangeVar(get_namespace_name(RelationGetNamespace(rel)),
pstrdup(RelationGetRelationName(rel)),
-1);

/*
* For T-SQL #temp tables with long names (>= NAMEDATALEN), the relation
* descriptor stores the name clipped to NAMEDATALEN-1 (63 chars) due to the
* Name type limitation. However, ENR stores the full untruncated name which
* is what subsequent lookups via RangeVarGetRelidExtended need to match.
* Replace the clipped relname with the full name from ENR.
*/
if (sql_dialect == SQL_DIALECT_TSQL &&
RelationGetRelationName(rel)[0] == '#')
{
EphemeralNamedRelation enr = get_ENR_withoid(currentQueryEnv,
RelationGetRelid(rel),
ENR_TSQL_TEMP, true);
if (enr)
atstmt->relation->relname = pstrdup(enr->md.name);
}
Comment thread
anju15bharti marked this conversation as resolved.
Outdated
atstmt->relation->inh = recurse;
atstmt->cmds = list_make1(cmd);
atstmt->objtype = OBJECT_TABLE; /* needn't be picky here */
Expand Down
Loading